From patchwork Thu Oct 12 08:21:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 824719 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QPINLF5a"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yCP3c1RMxz9t2l for ; Thu, 12 Oct 2017 19:22:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753409AbdJLIWe (ORCPT ); Thu, 12 Oct 2017 04:22:34 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:46127 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753246AbdJLIWc (ORCPT ); Thu, 12 Oct 2017 04:22:32 -0400 Received: by mail-lf0-f68.google.com with SMTP id g70so5051099lfl.3 for ; Thu, 12 Oct 2017 01:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1ytHUnqp0aKIZcM9Qma6cq5aRRAnVFXMKw4DYK8bPrs=; b=QPINLF5aA4LwW5mD3XeJs1oHr35CKXU9DoQiuPCrlE/H2kBp02pqzqwA+7yXOdOZyg wWzLWXC8glpfiwzpmiAv2fTVP5XKZnIACJhqJwqzgM8kFBYGuCNvCq0Ny2/A0AZUxJrK lftMHwzgv4Qdm72kSeRe6wsPuAQIqTT0OfHhmKKLc9S6smZBX82b3adRScTnLLaGkU62 606jhJ2F96/e8w2anr6QM/lVOZ8m4s0CZmtOWur9POIQ0M97pRmtl8y454ueEEJZvTyT vpGc1gqJVMiAWIPt3LPwEyar94GvfJn+wnj2fEyu/K7MZiJX+dgSzAv48c4hQe5GxM1P 1fog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1ytHUnqp0aKIZcM9Qma6cq5aRRAnVFXMKw4DYK8bPrs=; b=pOHVoAa/k1JQT30bN6FmL4WxUzfSty8Da/Xuj8Q5XBoc2qLv+18yokKCI81o/wMlFM V6e3kflHPCrHcm/72aiUFjfrTyVeWzh9CSu77AkHt4WwIa1cOY14L+Zr39KjUjJIzQkd IKPNm2pppIx/htmmVgZGYxb5W90mHWo06oMoujNTFtvxeuwxCkIudWYf9VdUj1ALcd3K ZnXryXE4GTQDPjLLyUQk5pYR6PUrqYqHUD++YQHChVqQ+hSgpSRgUXQq5A0GB+ektVH6 yKiREmiI46tNRLZ3ptE7i8CVVzn73s/v4zLtDenSUMar1BtgS9FEAIxC6lzDfTewn32K kNXA== X-Gm-Message-State: AMCzsaWEnFcRQWBppYIoNT55vtFn7GIU76gdFdvvbbgdNlwxrCcUsmRx 6GTjc7zzt2yXIbgBOSHydQA= X-Google-Smtp-Source: ABhQp+SxqH+pGMyh6dBHz1qmLjYQQ/FFzEg2J8xfzZ65gJmz2TmE4AIeehSh+oLjtbnXkud7GRVLvQ== X-Received: by 10.25.27.7 with SMTP id b7mr455269lfb.94.1507796550723; Thu, 12 Oct 2017 01:22:30 -0700 (PDT) Received: from linux-samsung.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id z81sm1596100lfd.87.2017.10.12.01.22.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 01:22:29 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: "David S . Miller" , netdev@vger.kernel.org Cc: Andrew Lunn , Florian Fainelli , Hauke Mehrtens , Jon Mason , Steve Lin , Tobias Klauser , bcm-kernel-feedback-list@broadcom.com, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH 2/2] net: bgmac: enable master mode for BCM54210E and B50212E PHYs Date: Thu, 12 Oct 2017 10:21:26 +0200 Message-Id: <20171012082126.30660-3-zajec5@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171012082126.30660-1-zajec5@gmail.com> References: <20171012082126.30660-1-zajec5@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rafał Miłecki There are 4 very similar PHYs: 0x600d84a1: BCM54210E (rev B0) 0x600d84a2: BCM54210E (rev B1) 0x600d84a5: B50212E (rev B0) 0x600d84a6: B50212E (rev B1) that need setting master mode manually. It's because they run in slave mode by default with Automatic Slave/Master configuration disabled which can lead to unreliable connection with massive ping loss. So far it was reported for a board with BCM47189 SoC and B50212E B1 PHY connected to the bgmac supported ethernet device. Telling PHY driver to setup PHY properly solves this issue. Signed-off-by: Rafał Miłecki --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c index 6322594ab260..6fe074c1588b 100644 --- a/drivers/net/ethernet/broadcom/bgmac-bcma.c +++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c @@ -184,13 +184,19 @@ static int bgmac_probe(struct bcma_device *core) if (!bgmac_is_bcm4707_family(core) && !(ci->id == BCMA_CHIP_ID_BCM53573 && core->core_unit == 1)) { + struct phy_device *phydev; + mii_bus = bcma_mdio_mii_register(bgmac); if (IS_ERR(mii_bus)) { err = PTR_ERR(mii_bus); goto err; } - bgmac->mii_bus = mii_bus; + + phydev = mdiobus_get_phy(bgmac->mii_bus, bgmac->phyaddr); + if (ci->id == BCMA_CHIP_ID_BCM53573 && phydev && + (phydev->drv->phy_id & phydev->drv->phy_id_mask) == PHY_ID_BCM54210E) + phydev->dev_flags |= PHY_BRCM_EN_MASTER_MODE; } if (core->bus->hosttype == BCMA_HOSTTYPE_PCI) {