[U-Boot] imx: mx7dsabresd: include BLK for MMC/eMMC support of driver model

Message ID 1507753798-20666-1-git-send-email-eric@nelint.com
State Superseded
Headers show
Series
  • [U-Boot] imx: mx7dsabresd: include BLK for MMC/eMMC support of driver model
Related show

Commit Message

Eric Nelson Oct. 11, 2017, 8:29 p.m.
Change-Id: I1bdfffe782a61a4c688f1bb56e85448024cd497b
Signed-off-by: Eric Nelson <eric@nelint.com>
---
 configs/mx7dsabresd_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Jagan Teki Oct. 11, 2017, 8:41 p.m. | #1
On Thu, Oct 12, 2017 at 1:59 AM, Eric Nelson <eric@nelint.com> wrote:
> Change-Id: I1bdfffe782a61a4c688f1bb56e85448024cd497b
> Signed-off-by: Eric Nelson <eric@nelint.com>

Reviewed-by: Jagan Teki <jagan@openedev.com>
Fabio Estevam Oct. 11, 2017, 8:50 p.m. | #2
Hi Eric,

That was the fix I was waiting for, thanks!

On Wed, Oct 11, 2017 at 5:29 PM, Eric Nelson <eric@nelint.com> wrote:

Please add a commit log and explain that this fixes a regression.

> Change-Id: I1bdfffe782a61a4c688f1bb56e85448024cd497b

Please remove this line.

Also, when you send a v2, please do the same change in
mx7dsabresd_secure_defconfig.

> Signed-off-by: Eric Nelson <eric@nelint.com>

Now I can boot a kernel successfully, thanks:

Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
Tom Rini Oct. 11, 2017, 8:51 p.m. | #3
On Wed, Oct 11, 2017 at 05:50:04PM -0300, Fabio Estevam wrote:
> Hi Eric,
> 
> That was the fix I was waiting for, thanks!
> 
> On Wed, Oct 11, 2017 at 5:29 PM, Eric Nelson <eric@nelint.com> wrote:
> 
> Please add a commit log and explain that this fixes a regression.
> 
> > Change-Id: I1bdfffe782a61a4c688f1bb56e85448024cd497b
> 
> Please remove this line.
> 
> Also, when you send a v2, please do the same change in
> mx7dsabresd_secure_defconfig.
> 
> > Signed-off-by: Eric Nelson <eric@nelint.com>
> 
> Now I can boot a kernel successfully, thanks:
> 
> Tested-by: Fabio Estevam <fabio.estevam@nxp.com>

Is there perhaps a dependency here we need to enforce via Kconfig so
this isn't a game of whack-a-mole?  Thanks!
Eric Nelson Oct. 11, 2017, 9:14 p.m. | #4
Hi Fabio,

On 10/11/2017 01:50 PM, Fabio Estevam wrote:
> Hi Eric,
> 
> That was the fix I was waiting for, thanks!
> 

Glad to hear it.

> On Wed, Oct 11, 2017 at 5:29 PM, Eric Nelson <eric@nelint.com> wrote:
> 
> Please add a commit log and explain that this fixes a regression.
> 

Okay. If you insist ;)

>> Change-Id: I1bdfffe782a61a4c688f1bb56e85448024cd497b
> 
> Please remove this line.
> 

Oops. I think we need to refresh checkpatch. I think the
version in the kernel tree checks for that.

> Also, when you send a v2, please do the same change in
> mx7dsabresd_secure_defconfig.
> 

Okay.

>> Signed-off-by: Eric Nelson <eric@nelint.com>
> 
> Now I can boot a kernel successfully, thanks:
> 
> Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
> 

Great.
Eric Nelson Oct. 11, 2017, 9:40 p.m. | #5
Hi Tom,

On 10/11/2017 01:51 PM, Tom Rini wrote:
> On Wed, Oct 11, 2017 at 05:50:04PM -0300, Fabio Estevam wrote:
>> Hi Eric,
>>
>> That was the fix I was waiting for, thanks!
>>
>> On Wed, Oct 11, 2017 at 5:29 PM, Eric Nelson <eric@nelint.com> wrote:
>>
>> Please add a commit log and explain that this fixes a regression.
>>
>>> Change-Id: I1bdfffe782a61a4c688f1bb56e85448024cd497b
>>
>> Please remove this line.
>>
>> Also, when you send a v2, please do the same change in
>> mx7dsabresd_secure_defconfig.
>>
>>> Signed-off-by: Eric Nelson <eric@nelint.com>
>>
>> Now I can boot a kernel successfully, thanks:
>>
>> Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Is there perhaps a dependency here we need to enforce via Kconfig so
> this isn't a game of whack-a-mole?  Thanks!
> 

We have a "default Y if DM" for it, which should be enough.

http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/block/Kconfig;h=26760895f99dd53370f9077f5b7213a1a6f241fe;hb=HEAD#l3

Commit 6fbbcfd explicitly disabled it when converting to
DM_MMC (secure_defconfig followed suit in commit 8ae5bb3), and
that's where the trouble came in.

Hmmm. A quick search shows that quite a few configurations
have this choice (CONFIG_DM_MMC without CONFIG_BLK):

~u-boot/configs$ git grep -l CONFIG_DM_MMC=y | xargs grep BLK
am335x_boneblack_vboot_defconfig:# CONFIG_BLK is not set
am335x_evm_defconfig:# CONFIG_BLK is not set
am335x_hs_evm_defconfig:# CONFIG_BLK is not set
am43xx_evm_defconfig:# CONFIG_BLK is not set
am43xx_evm_usbhost_boot_defconfig:# CONFIG_BLK is not set
am43xx_hs_evm_defconfig:# CONFIG_BLK is not set
am57xx_evm_defconfig:# CONFIG_BLK is not set
am57xx_hs_evm_defconfig:# CONFIG_BLK is not set
k2g_evm_defconfig:# CONFIG_BLK is not set
k2g_hs_evm_defconfig:# CONFIG_BLK is not set
ls1012aqds_qspi_defconfig:# CONFIG_BLK is not set
ls1012ardb_qspi_defconfig:# CONFIG_BLK is not set
mx6slevk_defconfig:# CONFIG_BLK is not set
mx6slevk_spinor_defconfig:# CONFIG_BLK is not set
mx6sllevk_defconfig:# CONFIG_BLK is not set
mx6sllevk_plugin_defconfig:# CONFIG_BLK is not set
mx6sxsabreauto_defconfig:# CONFIG_BLK is not set
mx6ull_14x14_evk_defconfig:# CONFIG_BLK is not set
mx6ull_14x14_evk_plugin_defconfig:# CONFIG_BLK is not set
mx7ulp_evk_defconfig:# CONFIG_BLK is not set
mx7ulp_evk_plugin_defconfig:# CONFIG_BLK is not set
omap3_logic_defconfig:# CONFIG_BLK is not set
pic32mzdask_defconfig:# CONFIG_BLK is not set

Are all of these broken?

I don't have any of the other boards, and am not in a
position to say whether there's a legitimate use case
for DM_MMC without BLK.

Patch

diff --git a/configs/mx7dsabresd_defconfig b/configs/mx7dsabresd_defconfig
index 795c4f2..144fb50 100644
--- a/configs/mx7dsabresd_defconfig
+++ b/configs/mx7dsabresd_defconfig
@@ -38,7 +38,6 @@  CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
-# CONFIG_BLK is not set
 CONFIG_DFU_MMC=y
 CONFIG_DFU_RAM=y
 CONFIG_DM_GPIO=y