dt-bindings: PCI: rcar: Correct example to match reality

Message ID 1507729813-21501-1-git-send-email-geert+renesas@glider.be
State Not Applicable
Headers show
Series
  • dt-bindings: PCI: rcar: Correct example to match reality
Related show

Commit Message

Geert Uytterhoeven Oct. 11, 2017, 1:50 p.m.
Correct the USB subnodes in the example, cfr. commit f7d569c1e6a6fa73
("ARM: dts: r8a779x: Fix PCI bus dtc warnings"):
  1. Drop the bogus 'device_type = "pci"' properties,
  2. Correct the unit addresses.

Update other bits in the example to match real use:
  1. Rename the USB subnodes from "pci" to "usb",
  2. Update the "phys" property.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Comments

Sergei Shtylyov Oct. 11, 2017, 4:13 p.m. | #1
On 10/11/2017 04:50 PM, Geert Uytterhoeven wrote:

> Correct the USB subnodes in the example, cfr. commit f7d569c1e6a6fa73
> ("ARM: dts: r8a779x: Fix PCI bus dtc warnings"):
>    1. Drop the bogus 'device_type = "pci"' properties,
>    2. Correct the unit addresses.
> 
> Update other bits in the example to match real use:
>    1. Rename the USB subnodes from "pci" to "usb",
>    2. Update the "phys" property.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring Oct. 17, 2017, 7:52 p.m. | #2
On Wed, Oct 11, 2017 at 03:50:13PM +0200, Geert Uytterhoeven wrote:
> Correct the USB subnodes in the example, cfr. commit f7d569c1e6a6fa73
> ("ARM: dts: r8a779x: Fix PCI bus dtc warnings"):
>   1. Drop the bogus 'device_type = "pci"' properties,
>   2. Correct the unit addresses.
> 
> Update other bits in the example to match real use:
>   1. Rename the USB subnodes from "pci" to "usb",
>   2. Update the "phys" property.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bjorn Helgaas Oct. 20, 2017, 5:30 p.m. | #3
On Wed, Oct 11, 2017 at 03:50:13PM +0200, Geert Uytterhoeven wrote:
> Correct the USB subnodes in the example, cfr. commit f7d569c1e6a6fa73
> ("ARM: dts: r8a779x: Fix PCI bus dtc warnings"):
>   1. Drop the bogus 'device_type = "pci"' properties,
>   2. Correct the unit addresses.
> 
> Update other bits in the example to match real use:
>   1. Rename the USB subnodes from "pci" to "usb",
>   2. Update the "phys" property.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied with acks from Sergei and Rob to pci/host-rcar for v4.15, thanks!

> ---
>  Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
> index 3d038638612b8ec2..9fe7e12a7bf37b7c 100644
> --- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
> +++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
> @@ -60,17 +60,15 @@ Example SoC configuration:
>  				 0x0800 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH
>  				 0x1000 0 0 2 &gic 0 108 IRQ_TYPE_LEVEL_HIGH>;
>  
> -		pci@0,1 {
> +		usb@1,0 {
>  			reg = <0x800 0 0 0 0>;
> -			device_type = "pci";
> -			phys = <&usbphy 0 0>;
> +			phys = <&usb0 0>;
>  			phy-names = "usb";
>  		};
>  
> -		pci@0,2 {
> +		usb@2,0 {
>  			reg = <0x1000 0 0 0 0>;
> -			device_type = "pci";
> -			phys = <&usbphy 0 0>;
> +			phys = <&usb0 0>;
>  			phy-names = "usb";
>  		};
>  	};
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
index 3d038638612b8ec2..9fe7e12a7bf37b7c 100644
--- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
+++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
@@ -60,17 +60,15 @@  Example SoC configuration:
 				 0x0800 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH
 				 0x1000 0 0 2 &gic 0 108 IRQ_TYPE_LEVEL_HIGH>;
 
-		pci@0,1 {
+		usb@1,0 {
 			reg = <0x800 0 0 0 0>;
-			device_type = "pci";
-			phys = <&usbphy 0 0>;
+			phys = <&usb0 0>;
 			phy-names = "usb";
 		};
 
-		pci@0,2 {
+		usb@2,0 {
 			reg = <0x1000 0 0 0 0>;
-			device_type = "pci";
-			phys = <&usbphy 0 0>;
+			phys = <&usb0 0>;
 			phy-names = "usb";
 		};
 	};