vlc: enable package on ARC

Message ID 20171011125005.25545-1-didin@synopsys.com
State Accepted
Headers show
Series
  • vlc: enable package on ARC
Related show

Commit Message

Evgeniy Didin Oct. 11, 2017, 12:50 p.m.
Now using arc-2017.09-rc1 toolchain it is possible to
build vlc package.

Note this patch has a prerequisite that updates ARC prebuilt toolchain,
http://patchwork.ozlabs.org/patch/824311/

Signed-off-by: Evgeniy Didin <didin@synopsys.com>
CC: Alexey Brodkin <abrodkin@synopsys.com>
CC: arc-buildroot@synopsys.com
CC: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/vlc/Config.in | 3 ---
 1 file changed, 3 deletions(-)

Comments

Thomas Petazzoni Jan. 1, 2018, 4:07 p.m. | #1
Hello,

On Wed, 11 Oct 2017 15:50:05 +0300, Evgeniy Didin wrote:
> Now using arc-2017.09-rc1 toolchain it is possible to
> build vlc package.
> 
> Note this patch has a prerequisite that updates ARC prebuilt toolchain,
> http://patchwork.ozlabs.org/patch/824311/

I've applied this patch. However, we still haven't received a new
version of the patch bumping the ARC external toolchain. Could you send
such an update in the near future ?

Thanks a lot!

Thomas
Alexey Brodkin Jan. 9, 2018, 2:03 p.m. | #2
Hi Thomas,

On Mon, 2018-01-01 at 17:07 +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed, 11 Oct 2017 15:50:05 +0300, Evgeniy Didin wrote:
> > Now using arc-2017.09-rc1 toolchain it is possible to
> > build vlc package.
> > 
> > Note this patch has a prerequisite that updates ARC prebuilt toolchain,
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.ozlabs.org_patch_824311_&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViX
> > O7breS55ytWkhpk5R81I&m=oXjZ7iSe0ULSbamHCYCDrRMyfbYSj9WjWCPS6OHy66I&s=gnkVm--myTL2YUFtDvz5VfzEZVxwxwtbjnw4mMxXGJY&e=
> 
> I've applied this patch. However, we still haven't received a new
> version of the patch bumping the ARC external toolchain. Could you send
> such an update in the near future ?

I think with https://git.buildroot.net/buildroot/commit/toolchain/toolchain-external/toolchain-external-synopsys-arc?id=c208203618cfaf3e9dcbcc8c987f99
27999c53ff in place your request is resolved right?

-Alexey

Patch

diff --git a/package/vlc/Config.in b/package/vlc/Config.in
index 78023fb500..166e7d256a 100644
--- a/package/vlc/Config.in
+++ b/package/vlc/Config.in
@@ -11,8 +11,6 @@  config BR2_PACKAGE_VLC
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
-	# ARC toolchain issue
-	depends on !BR2_arc
 	select BR2_PACKAGE_LIBVORBIS if BR2_PACKAGE_OPUS
 	select BR2_PACKAGE_VLC_OPENCV_BACKEND if BR2_PACKAGE_OPENCV
 	select BR2_PACKAGE_VLC_OPENCV3_BACKEND if BR2_PACKAGE_OPENCV3
@@ -36,6 +34,5 @@  config BR2_PACKAGE_VLC_OPENCV3_BACKEND
 
 comment "vlc needs a toolchain w/ C++, dynamic library, wchar, threads, headers >= 3.7"
 	depends on BR2_USE_MMU
-	depends on !BR2_arc
 	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_USE_WCHAR \
 		|| !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7