mpd: enable package for external ARC toolchain

Message ID 20171011121617.15179-1-didin@synopsys.com
State New
Headers show
Series
  • mpd: enable package for external ARC toolchain
Related show

Commit Message

Evgeniy Didin Oct. 11, 2017, 12:16 p.m.
Now using prebuilt arc-2017.09-rc1 toolchain it is possible to
build mpd package. The GCC patch solving the problem with pthread
support check now is the part of ARC toolchain.

Note this patch has a prerequisite that updates ARC prebuilt toolchain,
http://patchwork.ozlabs.org/patch/824311/

Signed-off-by: Evgeniy Didin <didin@synopsys.com>
CC: Alexey Brodkin <abrodkin@synopsys.com>
CC: arc-buildroot@synopsys.com
CC: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
 package/mpd/Config.in | 3 ---
 1 file changed, 3 deletions(-)

Comments

Arnout Vandecappelle Oct. 11, 2017, 8:14 p.m. | #1
Hi Evgeny,

On 11-10-17 14:16, Evgeniy Didin wrote:
> Now using prebuilt arc-2017.09-rc1 toolchain it is possible to
> build mpd package. The GCC patch solving the problem with pthread
> support check now is the part of ARC toolchain.
> 
> Note this patch has a prerequisite that updates ARC prebuilt toolchain,
> http://patchwork.ozlabs.org/patch/824311/

 In this case you should send the patches as a series. And if you don't, such a
comment should be below the --- line because it's not something that should stay
in the history.

 Otherwise:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout
> 
> Signed-off-by: Evgeniy Didin <didin@synopsys.com>
> CC: Alexey Brodkin <abrodkin@synopsys.com>
> CC: arc-buildroot@synopsys.com
> CC: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> ---
>  package/mpd/Config.in | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index 5991b6f4bb..b7b21672fc 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -7,8 +7,6 @@ menuconfig BR2_PACKAGE_MPD
>  	depends on BR2_TOOLCHAIN_HAS_ATOMIC
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
>  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
> -	# ARC toolchain issue
> -	depends on !BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC
>  	select BR2_PACKAGE_BOOST
>  	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>  	select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG)
> @@ -320,7 +318,6 @@ comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9"
>  	depends on BR2_TOOLCHAIN_HAS_ATOMIC
>  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
>  		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> -	depends on !BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC
>  
>  comment "mpd needs a toolchain not affected by GCC bug 64735"
>  	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
>
Thomas Petazzoni Oct. 11, 2017, 9:19 p.m. | #2
Hello,

On Wed, 11 Oct 2017 22:14:38 +0200, Arnout Vandecappelle wrote:
>  Hi Evgeny,
> 
> On 11-10-17 14:16, Evgeniy Didin wrote:
> > Now using prebuilt arc-2017.09-rc1 toolchain it is possible to
> > build mpd package. The GCC patch solving the problem with pthread
> > support check now is the part of ARC toolchain.
> > 
> > Note this patch has a prerequisite that updates ARC prebuilt toolchain,
> > http://patchwork.ozlabs.org/patch/824311/  

The ARC prebuilt toolchain is not tested by our autobuilders. The two
ARC configurations that we have are:

support/config-fragments/autobuild/br-arc-full-internal.config
support/config-fragments/autobuild/br-arcle-hs38.config

The first is a Buildroot internal toolchain, the second is an external
toolchain, built with Buildroot.

So we are not testing the Synopsys-provided pre-built toolchain, and
therefore the build failures that were detected in mpd and vlc were not
caused by Synopsys pre-built toolchain.

Best regards,

Thomas
Alexey Brodkin Oct. 11, 2017, 9:30 p.m. | #3
Hi Thomas,

On Wed, 2017-10-11 at 23:19 +0200, Thomas Petazzoni wrote:
> Hello,

> 

> On Wed, 11 Oct 2017 22:14:38 +0200, Arnout Vandecappelle wrote:

> > 

> >  Hi Evgeny,

> > 

> > On 11-10-17 14:16, Evgeniy Didin wrote:

> > > 

> > > Now using prebuilt arc-2017.09-rc1 toolchain it is possible to

> > > build mpd package. The GCC patch solving the problem with pthread

> > > support check now is the part of ARC toolchain.

> > > 

> > > Note this patch has a prerequisite that updates ARC prebuilt toolchain,

> > > https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.ozlabs.org_patch_824311_&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eV

> > > iXO7breS55ytWkhpk5R81I&m=g9SyhkcD7kkLjdVnxy_0PIxm6vf8vG9VuhheaCLHUOM&s=iTUcPjYUEl_yRBzAeiF08HNRskfS5hohJtPn80zE064&e=  

> 

> The ARC prebuilt toolchain is not tested by our autobuilders. The two

> ARC configurations that we have are:

> 

> support/config-fragments/autobuild/br-arc-full-internal.config

> support/config-fragments/autobuild/br-arcle-hs38.config

> 

> The first is a Buildroot internal toolchain, the second is an external

> toolchain, built with Buildroot.

> 

> So we are not testing the Synopsys-provided pre-built toolchain, and

> therefore the build failures that were detected in mpd and vlc were not

> caused by Synopsys pre-built toolchain.


Indeed, so then that note about prerequisite makes no sense.
Evgeniy will resend this patch with fixed commit message shortly.

-Alexey

Patch

diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index 5991b6f4bb..b7b21672fc 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -7,8 +7,6 @@  menuconfig BR2_PACKAGE_MPD
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
-	# ARC toolchain issue
-	depends on !BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG)
@@ -320,7 +318,6 @@  comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9"
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
 		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
-	depends on !BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC
 
 comment "mpd needs a toolchain not affected by GCC bug 64735"
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735