From patchwork Wed Oct 11 10:07:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 824322 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="JMQ6T3xE"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yBqRT37j0z9rvt for ; Wed, 11 Oct 2017 21:07:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdJKKHt (ORCPT ); Wed, 11 Oct 2017 06:07:49 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:44804 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbdJKKHr (ORCPT ); Wed, 11 Oct 2017 06:07:47 -0400 Received: by mail-lf0-f53.google.com with SMTP id 75so1481032lfx.1 for ; Wed, 11 Oct 2017 03:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=QFa8y+BcaMRYXUiecKpBiS1et1X2cf2IldB5FLWpSIg=; b=JMQ6T3xERDhWWxFDU0eCFEqHUwSJ+7HuNBMbOMHWSESpPKqZWV8zWeETvWPmaNA6KX 9KnX+3yifUFjuwrcQE3UmhPn/10HJlNlPkQnawk7uplEPayrYoE7SNWtwn5oKE6BEsYf mYniFvAhRXsiEuGWtJdNEf1cgJ0C53vDu3lUQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QFa8y+BcaMRYXUiecKpBiS1et1X2cf2IldB5FLWpSIg=; b=hLiAy4NxucwDzgEEqQ0ud/AuhgC1T14Y3v6vyoPTgSKcy8cS8gSFJZ2ymVgAy8LIuP SPkrX3ZWPMxQtPcYdW+xnUfjbAQcuid3/jdYJ9lNz7cR9gZg9kjig6oousmgoFSvJ6wP LzW1GV/JzlolUcWLagt3nGSxi4eI7O7p7PXK77K7TAuyY9YIXwfxx3oaxAJcYLwUwNUG 3B3LshGHktMczNJyZpEzfo7hf4AC4MTS3SP4UI1GE4QVYYAaQWQoI3/hIsGn5+zqQGFv xEmT8x0XLuVeuqZBKgRocBZmO75YSrpwKXHKB5Ki53Uk5m+4bBsf5dOmNLPy1RD/6zOP 6VDA== X-Gm-Message-State: AMCzsaUcMlRbUbtUuHVUR8t35M64S98jUS9OxOclOxx7U0JTjJMuujks 3sjyTPYXNH4M2mfTU4fuWh/XHjyLEGs= X-Google-Smtp-Source: AOwi7QBJdetsHC9hb3iphN1INUn+urWaWbKHMVy7PevBXX+l6cWWZxMskn2u2nGQO+4aDXbxjb3w1A== X-Received: by 10.46.117.30 with SMTP id q30mr4910143ljc.85.1507716466212; Wed, 11 Oct 2017 03:07:46 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id x28sm2266994ljd.88.2017.10.11.03.07.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Oct 2017 03:07:45 -0700 (PDT) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Linus Walleij , Phil Reid , Sebastian Reichel , Mika Westerberg , Andy Shevchenko , Peter Rosin , Andrey Smirnov Subject: [PATCH] pinctrl: Do not depend in GPIOLIB, select it Date: Wed, 11 Oct 2017 12:07:42 +0200 Message-Id: <20171011100742.9912-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.13.5 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Instead of depends on GPIOLIB and having to run around in Kconfig menus looking for why your device is not available, simply select it from the pin control drivers that need it. The Kconfig for GPIOLIB is improved, selectable and this should "just work". Cc: Phil Reid Cc: Sebastian Reichel Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Peter Rosin Cc: Andrey Smirnov Signed-off-by: Linus Walleij Reviewed-by: Andy Shevchenko Acked-by: Mika Westerberg --- drivers/pinctrl/Kconfig | 6 ++++-- drivers/pinctrl/intel/Kconfig | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 8da29e9e1bb2..034822c7144d 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -97,7 +97,7 @@ config PINCTRL_AT91PIO4 config PINCTRL_AMD tristate "AMD GPIO pin control" - depends on GPIOLIB + select GPIOLIB select GPIOLIB_IRQCHIP select PINCONF select GENERIC_PINCONF @@ -156,6 +156,7 @@ config PINCTRL_MCP23S08 tristate "Microchip MCP23xxx I/O expander" depends on SPI_MASTER || I2C depends on I2C || I2C=n + select GPIOLIB select GPIOLIB_IRQCHIP select REGMAP_I2C if I2C select REGMAP_SPI if SPI_MASTER @@ -224,10 +225,11 @@ config PINCTRL_SIRF config PINCTRL_SX150X bool "Semtech SX150x I2C GPIO expander pinctrl driver" - depends on GPIOLIB && I2C=y + depends on I2C=y select PINMUX select PINCONF select GENERIC_PINCONF + select GPIOLIB select GPIOLIB_IRQCHIP select REGMAP help diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig index f30720a752f3..7fb1b9937c39 100644 --- a/drivers/pinctrl/intel/Kconfig +++ b/drivers/pinctrl/intel/Kconfig @@ -5,7 +5,8 @@ if (X86 || COMPILE_TEST) config PINCTRL_BAYTRAIL bool "Intel Baytrail GPIO pin control" - depends on GPIOLIB && ACPI + depends on ACPI + select GPIOLIB select GPIOLIB_IRQCHIP select PINMUX select PINCONF