| Message ID | 20171011091703.32495-1-didin@synopsys.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | extern-toolchain: Bump ARC tools to arc-2017.09-rc1 | expand |
On 11-10-17 11:17, Evgeniy Didin wrote: > This commit bumps ARC prebuild toolchain to arc-2017.09-rc1 > > There might be subtle differences between uClibc configuration > compared to Buildroot's one. Native RPC now is disabled > because uClinc-ng has removed it. These two sentences are unrelated, right? I mean, Buildroot's uClibc hasn't had RPC since April... So better make that two paragraphs. Could you describe the subtle differences? > > Signed-off-by: Evgeniy Didin <didin@synopsys.com> > Cc: Alexey Brodkin <abrodkin@synopsys.com> > Cc: arc-buildroot@synopsys.com > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > --- > .../toolchain-external/toolchain-external-synopsys-arc/Config.in | 8 ++++---- > .../toolchain-external-synopsys-arc.hash | 8 ++++---- > .../toolchain-external-synopsys-arc.mk | 4 ++-- > 3 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in b/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in > index f438ea765d..cdf36d08e6 100644 > --- a/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in > +++ b/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in > @@ -1,18 +1,18 @@ > config BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC > - bool "Synopsys ARC 2016.09 toolchain" > + bool "Synopsys ARC 2017.09-rc1 toolchain" Do we really want the -rc1 toolchain? Shouldn't we wait for the release? It can't be because you want additional testing in the autobuilders, since this toolchain doesn't appear in support/config-fragments/autobuild. > depends on BR2_arc > depends on BR2_HOSTARCH = "x86_64" > select BR2_TOOLCHAIN_EXTERNAL_UCLIBC > select BR2_INSTALL_LIBSTDCPP > - select BR2_TOOLCHAIN_HAS_NATIVE_RPC > + #select BR2_TOOLCHAIN_HAS_NATIVE_RPC You shouldn't comment this line, just remove it. Regards, Arnout > select BR2_ENABLE_LOCALE > select BR2_USE_WCHAR > select BR2_TOOLCHAIN_HAS_THREADS > select BR2_TOOLCHAIN_HAS_THREADS_NPTL > select BR2_TOOLCHAIN_HAS_THREADS_DEBUG > select BR2_TOOLCHAIN_HAS_SSP > - select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8 > - select BR2_TOOLCHAIN_GCC_AT_LEAST_6 > + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_12 > + select BR2_TOOLCHAIN_GCC_AT_LEAST_7 > help > Toolchain for the ARC cores, from > https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases > diff --git a/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.hash b/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.hash > index c96f53b1f6..4e6d71205a 100644 > --- a/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.hash > +++ b/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.hash > @@ -1,5 +1,5 @@ > # Locally calculated > -sha256 9123e35510cc9105e5f9468d5154e0093770d7c11ed771c1a595ecf813692baf arc_gnu_2016.09_prebuilt_uclibc_le_arc700_linux_install.tar.gz > -sha256 3140066cdbda2df7ed0fb60424bbd9db740fb25393928e733234b0bf65508df2 arc_gnu_2016.09_prebuilt_uclibc_be_arc700_linux_install.tar.gz > -sha256 aa6edb2101b13df3ac59f8d8ccbcfba37a6f7882f0e03baa9d9883480dbed4e7 arc_gnu_2016.09_prebuilt_uclibc_le_archs_linux_install.tar.gz > -sha256 4de227bf73536a87784d88e5f10085b91ede62c76ef8fedf53b4bf2e215054cf arc_gnu_2016.09_prebuilt_uclibc_be_archs_linux_install.tar.gz > +sha256 db48969f433a69c1598208bbd4263341ccc75fb54004776e7030c29a12ab26c6 arc_gnu_2017.09-rc1_prebuilt_uclibc_le_arc700_linux_install.tar.gz > +sha256 cc1d0e2391d6a3856610aa4ca56fc4c1bc8a43252a28a924385ba2bdbe3025da arc_gnu_2017.09-rc1_prebuilt_uclibc_be_arc700_linux_install.tar.gz > +sha256 86f1b736e8ead5fba31fed74b620c5f951d30a1903ca95dccd80889612d324bd arc_gnu_2017.09-rc1_prebuilt_uclibc_le_archs_linux_install.tar.gz > +sha256 e655beef55bd3d1ced5326ceab499b6b694d71a4d3f9c6e5a48364eb486d52f3 arc_gnu_2017.09-rc1_prebuilt_uclibc_be_archs_linux_install.tar.gz > diff --git a/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.mk b/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.mk > index f4cb7b73a1..cb19f9bd14 100644 > --- a/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.mk > +++ b/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.mk > @@ -4,8 +4,8 @@ > # > ################################################################################ > > -TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_VERSION = 2016.09 > -TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_SITE = https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/download/arc-$(TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_VERSION)-release > +TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_VERSION = 2017.09-rc1 > +TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_SITE = https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/download/arc-$(TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_VERSION) > > ifeq ($(BR2_arc750d)$(BR2_arc770d),y) > TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_CORE = arc700 >
Hi Arnout, On Wed, 2017-10-11 at 22:14 +0200, Arnout Vandecappelle wrote: > > On 11-10-17 11:17, Evgeniy Didin wrote: > > > > This commit bumps ARC prebuild toolchain to arc-2017.09-rc1 > > > > There might be subtle differences between uClibc configuration > > compared to Buildroot's one. Native RPC now is disabled > > because uClinc-ng has removed it. > > These two sentences are unrelated, right? I mean, Buildroot's uClibc hasn't had > RPC since April... So better make that two paragraphs. Probably so. > Could you describe the subtle differences? Well we may do a full side-by-side comparison of uClibc's defconfigs but that barely makes a lot of sense. I mean we used to use some configuration which was formed as it was in years and not all choices I may justify and explain. Still we're slowly drifting to Buildroot's uClibc defconfig with pretty much every our release but not yet there... and Buildroot's defconfig changes with time but we cannot change ours in the middle of development cycle. Again we may do that comparison and identify all [meaningful] differences but not sure what it gives. > > > > > > Signed-off-by: Evgeniy Didin <didin@synopsys.com> > > Cc: Alexey Brodkin <abrodkin@synopsys.com> > > Cc: arc-buildroot@synopsys.com > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > > > --- > > .../toolchain-external/toolchain-external-synopsys-arc/Config.in | 8 ++++---- > > .../toolchain-external-synopsys-arc.hash | 8 ++++---- > > .../toolchain-external-synopsys-arc.mk | 4 ++-- > > 3 files changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in b/toolchain/toolchain-external/toolchain-external-synopsys- > > arc/Config.in > > index f438ea765d..cdf36d08e6 100644 > > --- a/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in > > +++ b/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in > > @@ -1,18 +1,18 @@ > > config BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC > > - bool "Synopsys ARC 2016.09 toolchain" > > + bool "Synopsys ARC 2017.09-rc1 toolchain" > > Do we really want the -rc1 toolchain? Shouldn't we wait for the release? It > can't be because you want additional testing in the autobuilders, since this > toolchain doesn't appear in support/config-fragments/autobuild. Well we used to have ARC prebuilt toolchain in autobuilder if I'm not mistaken. But due to some significant deviations from Buildroot defaults like missing IPv6 back in the day it got nuked. Maybe Thomas can remember it better... for some reason I cannot find any signs of ARC prebuilt tools in https://git.busybox.net/buildroot-test/ so I might be wrong here. But indeed we wanted to get some more testing for that pre-built toolchain and catch a couple of issues before cutting rc2 and final release. And essentially once and if that patch gets accepted the plan was to submit a config-fragment for it. > > > > depends on BR2_arc > > depends on BR2_HOSTARCH = "x86_64" > > select BR2_TOOLCHAIN_EXTERNAL_UCLIBC > > select BR2_INSTALL_LIBSTDCPP > > - select BR2_TOOLCHAIN_HAS_NATIVE_RPC > > + #select BR2_TOOLCHAIN_HAS_NATIVE_RPC > > You shouldn't comment this line, just remove it. Good catch - we'll fix that. -Alexey
On 11-10-17 22:51, Alexey Brodkin wrote: > Hi Arnout, > > On Wed, 2017-10-11 at 22:14 +0200, Arnout Vandecappelle wrote: >> >> On 11-10-17 11:17, Evgeniy Didin wrote: >>> >>> This commit bumps ARC prebuild toolchain to arc-2017.09-rc1 >>> >>> There might be subtle differences between uClibc configuration >>> compared to Buildroot's one. Native RPC now is disabled >>> because uClinc-ng has removed it. >> >> These two sentences are unrelated, right? I mean, Buildroot's uClibc hasn't had >> RPC since April... So better make that two paragraphs. > > Probably so. > >> Could you describe the subtle differences? > > Well we may do a full side-by-side comparison of uClibc's defconfigs > but that barely makes a lot of sense. I mean we used to use some configuration > which was formed as it was in years and not all choices I may justify and explain. > > Still we're slowly drifting to Buildroot's uClibc defconfig with pretty much every > our release but not yet there... and Buildroot's defconfig changes with time but > we cannot change ours in the middle of development cycle. It doesn't change that much. Since 2016.09, we added UCLIBC_HAS_WORDEXP and UCLIBC_HAS_LIBINTL, nothing more. > > Again we may do that comparison and identify all [meaningful] differences > but not sure what it gives. There are a few important ones, like ftw. Just do a log of package/uclibc/uClibc-ng.config to see which ones were added over the years and why. If you don't have some of those, and this toolchain gets added to the autobuilders, you're going to get build failures because of those. This is BTW the only predefined external toolchain with uClibc. >>> Signed-off-by: Evgeniy Didin <didin@synopsys.com> >>> Cc: Alexey Brodkin <abrodkin@synopsys.com> >>> Cc: arc-buildroot@synopsys.com >>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >>> >>> --- >>> .../toolchain-external/toolchain-external-synopsys-arc/Config.in | 8 ++++---- >>> .../toolchain-external-synopsys-arc.hash | 8 ++++---- >>> .../toolchain-external-synopsys-arc.mk | 4 ++-- >>> 3 files changed, 10 insertions(+), 10 deletions(-) >>> >>> diff --git a/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in b/toolchain/toolchain-external/toolchain-external-synopsys- >>> arc/Config.in >>> index f438ea765d..cdf36d08e6 100644 >>> --- a/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in >>> +++ b/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in >>> @@ -1,18 +1,18 @@ >>> config BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC >>> - bool "Synopsys ARC 2016.09 toolchain" >>> + bool "Synopsys ARC 2017.09-rc1 toolchain" >> >> Do we really want the -rc1 toolchain? Shouldn't we wait for the release? It >> can't be because you want additional testing in the autobuilders, since this >> toolchain doesn't appear in support/config-fragments/autobuild. > > Well we used to have ARC prebuilt toolchain in autobuilder if I'm not mistaken. There is support/config-fragments/autobuild/br-arcle-hs38.config but that's not the Synopsys one, it's one built by Thomas. > But due to some significant deviations from Buildroot defaults like missing IPv6 > back in the day it got nuked. Right, so that's what I refer to above. > Maybe Thomas can remember it better... for some > reason I cannot find any signs of ARC prebuilt tools in > https://git.busybox.net/buildroot-test/ so I might be wrong here. > > But indeed we wanted to get some more testing for that pre-built toolchain > and catch a couple of issues before cutting rc2 and final release. Well, that testing is probably not going to happen if it's not in the autobuilders, right? > And essentially once and if that patch gets accepted the plan was to > submit a config-fragment for it. OK! But then please first do a diff of the uClibc configs to check if anything important is missing. Regards, Arnout >>> >>> depends on BR2_arc >>> depends on BR2_HOSTARCH = "x86_64" >>> select BR2_TOOLCHAIN_EXTERNAL_UCLIBC >>> select BR2_INSTALL_LIBSTDCPP >>> - select BR2_TOOLCHAIN_HAS_NATIVE_RPC >>> + #select BR2_TOOLCHAIN_HAS_NATIVE_RPC >> >> You shouldn't comment this line, just remove it. > > Good catch - we'll fix that. > > -Alexey >
diff --git a/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in b/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in index f438ea765d..cdf36d08e6 100644 --- a/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in +++ b/toolchain/toolchain-external/toolchain-external-synopsys-arc/Config.in @@ -1,18 +1,18 @@ config BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC - bool "Synopsys ARC 2016.09 toolchain" + bool "Synopsys ARC 2017.09-rc1 toolchain" depends on BR2_arc depends on BR2_HOSTARCH = "x86_64" select BR2_TOOLCHAIN_EXTERNAL_UCLIBC select BR2_INSTALL_LIBSTDCPP - select BR2_TOOLCHAIN_HAS_NATIVE_RPC + #select BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_ENABLE_LOCALE select BR2_USE_WCHAR select BR2_TOOLCHAIN_HAS_THREADS select BR2_TOOLCHAIN_HAS_THREADS_NPTL select BR2_TOOLCHAIN_HAS_THREADS_DEBUG select BR2_TOOLCHAIN_HAS_SSP - select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8 - select BR2_TOOLCHAIN_GCC_AT_LEAST_6 + select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_12 + select BR2_TOOLCHAIN_GCC_AT_LEAST_7 help Toolchain for the ARC cores, from https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases diff --git a/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.hash b/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.hash index c96f53b1f6..4e6d71205a 100644 --- a/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.hash +++ b/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.hash @@ -1,5 +1,5 @@ # Locally calculated -sha256 9123e35510cc9105e5f9468d5154e0093770d7c11ed771c1a595ecf813692baf arc_gnu_2016.09_prebuilt_uclibc_le_arc700_linux_install.tar.gz -sha256 3140066cdbda2df7ed0fb60424bbd9db740fb25393928e733234b0bf65508df2 arc_gnu_2016.09_prebuilt_uclibc_be_arc700_linux_install.tar.gz -sha256 aa6edb2101b13df3ac59f8d8ccbcfba37a6f7882f0e03baa9d9883480dbed4e7 arc_gnu_2016.09_prebuilt_uclibc_le_archs_linux_install.tar.gz -sha256 4de227bf73536a87784d88e5f10085b91ede62c76ef8fedf53b4bf2e215054cf arc_gnu_2016.09_prebuilt_uclibc_be_archs_linux_install.tar.gz +sha256 db48969f433a69c1598208bbd4263341ccc75fb54004776e7030c29a12ab26c6 arc_gnu_2017.09-rc1_prebuilt_uclibc_le_arc700_linux_install.tar.gz +sha256 cc1d0e2391d6a3856610aa4ca56fc4c1bc8a43252a28a924385ba2bdbe3025da arc_gnu_2017.09-rc1_prebuilt_uclibc_be_arc700_linux_install.tar.gz +sha256 86f1b736e8ead5fba31fed74b620c5f951d30a1903ca95dccd80889612d324bd arc_gnu_2017.09-rc1_prebuilt_uclibc_le_archs_linux_install.tar.gz +sha256 e655beef55bd3d1ced5326ceab499b6b694d71a4d3f9c6e5a48364eb486d52f3 arc_gnu_2017.09-rc1_prebuilt_uclibc_be_archs_linux_install.tar.gz diff --git a/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.mk b/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.mk index f4cb7b73a1..cb19f9bd14 100644 --- a/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.mk +++ b/toolchain/toolchain-external/toolchain-external-synopsys-arc/toolchain-external-synopsys-arc.mk @@ -4,8 +4,8 @@ # ################################################################################ -TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_VERSION = 2016.09 -TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_SITE = https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/download/arc-$(TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_VERSION)-release +TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_VERSION = 2017.09-rc1 +TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_SITE = https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/download/arc-$(TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_VERSION) ifeq ($(BR2_arc750d)$(BR2_arc770d),y) TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_CORE = arc700
This commit bumps ARC prebuild toolchain to arc-2017.09-rc1 There might be subtle differences between uClibc configuration compared to Buildroot's one. Native RPC now is disabled because uClinc-ng has removed it. Signed-off-by: Evgeniy Didin <didin@synopsys.com> Cc: Alexey Brodkin <abrodkin@synopsys.com> Cc: arc-buildroot@synopsys.com Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- .../toolchain-external/toolchain-external-synopsys-arc/Config.in | 8 ++++---- .../toolchain-external-synopsys-arc.hash | 8 ++++---- .../toolchain-external-synopsys-arc.mk | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-)