[01/12] cifs: initialize rsp_iov in SMB2_negotiate

Message ID 20171011015927.7669-2-lsahlber@redhat.com
State New
Headers show
Series
  • cifs: various fixes for NULL pointers
Related show

Commit Message

Leif Sahlberg Oct. 11, 2017, 1:59 a.m.
Initialize rsp_iov so that when rsp is assigned we know it is either NULL
or a valid pointer.

Otherwise, if SendReceive2() returns an error without setting rsp_iov
we could end up calling free_rsp_buf() on an uninitialized pointer.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
---
 fs/cifs/smb2pdu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 6ff4c275ca9a..08701b6125b9 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -470,7 +470,7 @@  SMB2_negotiate(const unsigned int xid, struct cifs_ses *ses)
 	struct smb2_negotiate_req *req;
 	struct smb2_negotiate_rsp *rsp;
 	struct kvec iov[1];
-	struct kvec rsp_iov;
+	struct kvec rsp_iov = { NULL, 0 };
 	int rc = 0;
 	int resp_buftype;
 	struct TCP_Server_Info *server = ses->server;