From patchwork Tue Oct 10 22:41:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Dilger X-Patchwork-Id: 824107 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yBXJz3Bnjz9t5C for ; Wed, 11 Oct 2017 09:46:11 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932307AbdJJWqK (ORCPT ); Tue, 10 Oct 2017 18:46:10 -0400 Received: from smtp-out-no.shaw.ca ([64.59.134.12]:35459 "EHLO smtp-out-no.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932243AbdJJWqK (ORCPT ); Tue, 10 Oct 2017 18:46:10 -0400 Received: from cabot.adilger.int ([70.77.216.213]) by shaw.ca with SMTP id 23DHeIOsTI8mC23DIevhBr; Tue, 10 Oct 2017 16:41:25 -0600 X-Authority-Analysis: v=2.2 cv=HahkdmM8 c=1 sm=1 tr=0 a=BQvS1EmAg2ttxjPVUuc1UQ==:117 a=BQvS1EmAg2ttxjPVUuc1UQ==:17 a=RPJ6JBhKAAAA:8 a=tggxZiGd8EwEKHqJSBcA:9 a=fa_un-3J20JGBB2Tu-mn:22 From: Andreas Dilger To: tytso@mit.edu Cc: linux-ext4@vger.kernel.org, Andreas Dilger Subject: [PATCH] misc: quiet llvm build warnings Date: Tue, 10 Oct 2017 16:41:23 -0600 Message-Id: <1507675283-70118-1-git-send-email-adilger@dilger.ca> X-Mailer: git-send-email 1.8.0 X-CMAE-Envelope: MS4wfF42kd8DFG2AITXYttzw4SOcmHhGJUrppzQca6invHgQpGtaU13yLWGM1YTBkPc7cJN2lF4HMiXD2UGKsrRkUHGTtuyBACxt79bWx684z4OxoTYk5Tjg GSRdWCbVI4ICgk+VhoHTEosgYmKckGUk4p52a9wiOmmAnE3WZAf5h+hAZTHQbeWAo4N0iVeDT2PBD1ASRrpKlbXCHSI5q+z9xHRn1cE3vB6HiBbuxSjwrQa5 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Quiet some relatively harmless build warnings: mkquota.c:527:15: warning: format specifies type 'long' but the argument has type 'qsize_t' (aka 'long long') [-Wformat] dq->dq_id, dq->dq_dqb.dqb_curspace, ^~~~~~~~~~~~~~~~~~~~~~~ tune2fs.c:928:18: warning: '&&' within '||' [-Wlogical-op-parentheses] if (pass == 1 && (inode->i_flags & EXT4_EA_INODE_FL) || ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~ tune2fs.c:928:18: place parentheses around '&&' to silence warning Signed-off-by: Andreas Dilger --- lib/support/mkquota.c | 2 +- misc/tune2fs.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/support/mkquota.c b/lib/support/mkquota.c index 11a878e..4251e46 100644 --- a/lib/support/mkquota.c +++ b/lib/support/mkquota.c @@ -523,7 +523,7 @@ static int scan_dquots_callback(struct dquot *dquot, void *cb_data) dq->dq_dqb.dqb_curinodes != dquot->dq_dqb.dqb_curinodes) { scan_data->usage_is_inconsistent = 1; fprintf(stderr, "[QUOTA WARNING] Usage inconsistent for ID %u:" - "actual (%ld, %ld) != expected (%ld, %ld)\n", + "actual (%lld, %lld) != expected (%lld, %lld)\n", dq->dq_id, dq->dq_dqb.dqb_curspace, dq->dq_dqb.dqb_curinodes, dquot->dq_dqb.dqb_curspace, diff --git a/misc/tune2fs.c b/misc/tune2fs.c index 9b53dc2..c7c1d6d 100644 --- a/misc/tune2fs.c +++ b/misc/tune2fs.c @@ -925,8 +925,8 @@ static void rewrite_inodes(ext2_filsys fs) if (!ino) break; - if (pass == 1 && (inode->i_flags & EXT4_EA_INODE_FL) || - pass == 2 && !(inode->i_flags & EXT4_EA_INODE_FL)) + if ((pass == 1 && (inode->i_flags & EXT4_EA_INODE_FL))|| + (pass == 2 && !(inode->i_flags & EXT4_EA_INODE_FL))) rewrite_one_inode(&ctx, ino, inode); } while (ino);