| Message ID | 1507665203-29109-1-git-send-email-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | acpi: madt: check GICD's system vector according to mantis 1819 (ACPI 6.2a) | expand |
On 10/10/17 20:53, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/madt/madt.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c > index a280cc8..3bbaf2f 100644 > --- a/src/acpi/madt/madt.c > +++ b/src/acpi/madt/madt.c > @@ -1114,6 +1114,18 @@ static int madt_gicd(fwts_framework *fw, > > /* TODO: is the physical base address required to be non-zero? */ > > + if (gicd->system_vector_base) > + fwts_failed(fw, LOG_LEVEL_LOW, > + "MADTGICDSystemVectorBaseNonZero", > + "MADT %s system vector base field should be zero, " > + "instead got 0x%" PRIx32 ".", > + madt_sub_names[hdr->type], > + gicd->system_vector_base); > + else > + fwts_passed(fw, > + "MADT %s system vector base field is properly set " > + "to zero.", madt_sub_names[hdr->type]); > + > if (gicd->gic_version != 0 && gicd->gic_version > 4) > fwts_failed(fw, LOG_LEVEL_LOW, > "SPECMADTGICDVersion", > Acked-by: Colin Ian King <colin.king@canonical.com>
On 10/11/2017 03:53 AM, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/madt/madt.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c > index a280cc8..3bbaf2f 100644 > --- a/src/acpi/madt/madt.c > +++ b/src/acpi/madt/madt.c > @@ -1114,6 +1114,18 @@ static int madt_gicd(fwts_framework *fw, > > /* TODO: is the physical base address required to be non-zero? */ > > + if (gicd->system_vector_base) > + fwts_failed(fw, LOG_LEVEL_LOW, > + "MADTGICDSystemVectorBaseNonZero", > + "MADT %s system vector base field should be zero, " > + "instead got 0x%" PRIx32 ".", > + madt_sub_names[hdr->type], > + gicd->system_vector_base); > + else > + fwts_passed(fw, > + "MADT %s system vector base field is properly set " > + "to zero.", madt_sub_names[hdr->type]); > + > if (gicd->gic_version != 0 && gicd->gic_version > 4) > fwts_failed(fw, LOG_LEVEL_LOW, > "SPECMADTGICDVersion", > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c index a280cc8..3bbaf2f 100644 --- a/src/acpi/madt/madt.c +++ b/src/acpi/madt/madt.c @@ -1114,6 +1114,18 @@ static int madt_gicd(fwts_framework *fw, /* TODO: is the physical base address required to be non-zero? */ + if (gicd->system_vector_base) + fwts_failed(fw, LOG_LEVEL_LOW, + "MADTGICDSystemVectorBaseNonZero", + "MADT %s system vector base field should be zero, " + "instead got 0x%" PRIx32 ".", + madt_sub_names[hdr->type], + gicd->system_vector_base); + else + fwts_passed(fw, + "MADT %s system vector base field is properly set " + "to zero.", madt_sub_names[hdr->type]); + if (gicd->gic_version != 0 && gicd->gic_version > 4) fwts_failed(fw, LOG_LEVEL_LOW, "SPECMADTGICDVersion",
Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/acpi/madt/madt.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)