| Message ID | 20171010181542.24168-2-quintela@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Make xbzrle_cache_size a migration parameter | expand |
On Tue, Oct 10, 2017 at 08:15:33PM +0200, Juan Quintela wrote: > They were missing when introduced on the tree > > Signed-off-by: Juan Quintela <quintela@redhat.com> > --- > migration/migration.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/migration/migration.c b/migration/migration.c > index 98429dc843..fb62a639d8 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -865,6 +865,12 @@ static void migrate_params_test_apply(MigrateSetParameters *params, > if (params->has_block_incremental) { > dest->block_incremental = params->block_incremental; > } (newline?) > + if (params->has_x_multifd_channels) { > + dest->x_multifd_channels = params->x_multifd_channels; > + } (newline?) > + if (params->has_x_multifd_page_count) { > + dest->x_multifd_page_count = params->x_multifd_page_count; > + } > } > > static void migrate_params_apply(MigrateSetParameters *params) > -- > 2.13.6 > Reviewed-by: Peter Xu <peterx@redhat.com>
Peter Xu <peterx@redhat.com> wrote: > On Tue, Oct 10, 2017 at 08:15:33PM +0200, Juan Quintela wrote: >> They were missing when introduced on the tree >> >> Signed-off-by: Juan Quintela <quintela@redhat.com> >> --- >> migration/migration.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/migration/migration.c b/migration/migration.c >> index 98429dc843..fb62a639d8 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -865,6 +865,12 @@ static void migrate_params_test_apply(MigrateSetParameters *params, >> if (params->has_block_incremental) { >> dest->block_incremental = params->block_incremental; >> } > > (newline?) I preffer without it. At least in migration we have code with both approachs. > >> + if (params->has_x_multifd_channels) { >> + dest->x_multifd_channels = params->x_multifd_channels; >> + } > > (newline?) > >> + if (params->has_x_multifd_page_count) { >> + dest->x_multifd_page_count = params->x_multifd_page_count; >> + } >> } >> >> static void migrate_params_apply(MigrateSetParameters *params) >> -- >> 2.13.6 >> > > Reviewed-by: Peter Xu <peterx@redhat.com> Thanks.
diff --git a/migration/migration.c b/migration/migration.c index 98429dc843..fb62a639d8 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -865,6 +865,12 @@ static void migrate_params_test_apply(MigrateSetParameters *params, if (params->has_block_incremental) { dest->block_incremental = params->block_incremental; } + if (params->has_x_multifd_channels) { + dest->x_multifd_channels = params->x_multifd_channels; + } + if (params->has_x_multifd_page_count) { + dest->x_multifd_page_count = params->x_multifd_page_count; + } } static void migrate_params_apply(MigrateSetParameters *params)
They were missing when introduced on the tree Signed-off-by: Juan Quintela <quintela@redhat.com> --- migration/migration.c | 6 ++++++ 1 file changed, 6 insertions(+)