[committed] Fix return type on stack clash protection hook

Message ID b5e2b4e4-ce95-ce1f-66cb-e8cefb238b9e@redhat.com
State New
Headers show
Series
  • [committed] Fix return type on stack clash protection hook
Related show

Commit Message

Jeff Law Oct. 10, 2017, 6:42 a.m.
Pointed out in IRC.   The intent as well as the docs and prototype had
the return type as a bool, but the default implementation used
HOST_WIDE_INT.  Opps.

This fixes the default implementation to match the intent, docs &
prototype.  Bootstrapped and regression tested.  Installing on the trunk
as obvious.

Jeff
commit fdc63db3b0343eaa3cdde6d5c143fbd80a851da6
Author: Jeff Law <law@torsion.usersys.redhat.com>
Date:   Mon Oct 9 17:29:58 2017 -0400

            * targhooks.c (default_stack_clash_protection_final_dynamic_probe): Fix
            return type to match prototype and documentation.

Patch

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 202dd89b957..30bbeb5ad82 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@ 
+2017-10-09  Jeff Law  <law@redhat.com>
+
+	* targhooks.c (default_stack_clash_protection_final_dynamic_probe): Fix
+	return type to match prototype and documentation.
+
 2010-10-09  Segher Boessenkool  <segher@kernel.crashing.org>
 
 	* config/rs6000/rs6000.c (processor_costs): Move to ...
diff --git a/gcc/targhooks.c b/gcc/targhooks.c
index d56f53d35d8..8dbf8a14970 100644
--- a/gcc/targhooks.c
+++ b/gcc/targhooks.c
@@ -2235,7 +2235,7 @@  default_excess_precision (enum excess_precision_type ATTRIBUTE_UNUSED)
   return FLT_EVAL_METHOD_PROMOTE_TO_FLOAT;
 }
 
-HOST_WIDE_INT
+bool
 default_stack_clash_protection_final_dynamic_probe (rtx residual ATTRIBUTE_UNUSED)
 {
   return 0;