diff mbox series

[10/42] tpm: remove configure_tpm() hop

Message ID	20171009225623.29232-11-marcandre.lureau@redhat.com
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C4444356EC From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com> To: qemu-devel@nongnu.org Date: Tue, 10 Oct 2017 00:55:51 +0200 Message-Id: <20171009225623.29232-11-marcandre.lureau@redhat.com> In-Reply-To: <20171009225623.29232-1-marcandre.lureau@redhat.com> References: <20171009225623.29232-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 10/42] tpm: remove configure_tpm() hop Precedence: list Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>, amarnath.valluri@intel.com, stefanb@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	TPM: code cleanup & CRB device \| expand [00/42] TPM: code cleanup & CRB device [01/42] tpm-tis: remove unused hw_access argument [02/42] tpm-tis: remove RAISE_STS_IRQ [03/42] tpm: make tpm_get_backend_driver() static [04/42] tpm: lookup tpm backend class in tpm_driver_find_by_type() [05/42] tpm: replace tpm_get_backend_driver() to drop be_drivers [06/42] tpm: remove tpm_register_driver() [07/42] tpm: move TPMSizedBuffer to tpm_tis.h [08/42] tpm: remove TPMDriverOps [09/42] tpm: remove init() class method [10/42] tpm: remove configure_tpm() hop [11/42] tpm: remove unused TPMBackendCmd [12/42] tpm: remove needless cast [13/42] tpm: remove locty argument from receive_cb [14/42] tpm: add TPMBackendCmd to hold the request state [15/42] tpm-emulator: fix error handling [16/42] tpm: remove locty_data from TPMState [17/42] tpm-tis: move TPMState to TIS header [18/42] tpm-tis: remove tpm_tis.h header [19/42] tpm-tis: fold TPMTISEmuState in TPMState [20/42] tpm: add a QOM TPM interface [21/42] tpm: move recv_data_callback to TPM interface [22/42] tpm-backend: store TPMIf interface, improve backend_init() [23/42] tpm-tis: no longer expose TPMState [24/42] tpm-be: call request_completed() out of thread [25/42] tpm-be: report error instead of front-end [26/42] tpm-be: ask model to the TPM interface [27/42] tpm: remove unused opened code [28/42] tpm-passthrough: don't save guessed cancel_path in options [29/42] tpm-be: update optional function pointers [30/42] tpm-passthrough: pass TPMPassthruState to handle_device_opts [31/42] tpm-backend: move set 'id' to common code [32/42] tpm-passthrough: make it safer to destroy after creation [33/42] tpm-passthrough: remove error cleanup from handle_device_opts [34/42] tpm-passthrough: workaround a possible race [35/42] tpm-tis: simplify header inclusion [36/42] tpm: rename qemu_find_tpm() -> qemu_find_tpm_be() [37/42] tpm: lookup the the TPM interface instead of TIS device [38/42] tpm: add TPM interface to lookup TPM version [39/42] tpm: add tpm_cmd_get_size() to tpm_util [40/42] acpi: change TPM TIS data conditions [41/42] tpm-emulator: add a FIXME comment about blocking cancel [42/42] WIP: add TPM CRB device

Commit Message

Marc-André Lureau Oct. 9, 2017, 10:55 p.m. UTC

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tpm.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Stefan Berger Oct. 10, 2017, 3:31 p.m. UTC | #1

On 10/09/2017 06:55 PM, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

> ---
>   tpm.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/tpm.c b/tpm.c
> index 4882501bd7..45520f555d 100644
> --- a/tpm.c
> +++ b/tpm.c
> @@ -86,7 +86,7 @@ TPMBackend *qemu_find_tpm(const char *id)
>       return NULL;
>   }
>   
> -static int configure_tpm(QemuOpts *opts)
> +static int tpm_init_tpmdev(void *dummy, QemuOpts *opts, Error **errp)
>   {
>       const char *value;
>       const char *id;
> @@ -145,11 +145,6 @@ static int configure_tpm(QemuOpts *opts)
>       return 0;
>   }
>   
> -static int tpm_init_tpmdev(void *dummy, QemuOpts *opts, Error **errp)
> -{
> -    return configure_tpm(opts);
> -}
> -
>   /*
>    * Walk the list of TPM backend drivers that are in use and call their
>    * destroy function to have them cleaned up.

diff mbox series

Patch

diff --git a/tpm.c b/tpm.c
index 4882501bd7..45520f555d 100644
--- a/tpm.c
+++ b/tpm.c
@@ -86,7 +86,7 @@  TPMBackend *qemu_find_tpm(const char *id)
     return NULL;
 }
 
-static int configure_tpm(QemuOpts *opts)
+static int tpm_init_tpmdev(void *dummy, QemuOpts *opts, Error **errp)
 {
     const char *value;
     const char *id;
@@ -145,11 +145,6 @@  static int configure_tpm(QemuOpts *opts)
     return 0;
 }
 
-static int tpm_init_tpmdev(void *dummy, QemuOpts *opts, Error **errp)
-{
-    return configure_tpm(opts);
-}
-
 /*
  * Walk the list of TPM backend drivers that are in use and call their
  * destroy function to have them cleaned up.