[v2,1/2] pinctrl: sh-pfc: r8a7795: fix trivial typo in comment

Message ID 20171009083725.6474-1-wsa+renesas@sang-engineering.com
State New
Headers show
Series
  • [v2,1/2] pinctrl: sh-pfc: r8a7795: fix trivial typo in comment
Related show

Commit Message

Wolfram Sang Oct. 9, 2017, 8:37 a.m.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Change since V1 for both patches:
	* corrected authorship email address (sorry for the noise!)

 drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Oct. 11, 2017, 9:28 a.m. | #1
Hi Wolfram,

On Mon, Oct 9, 2017 at 10:37 AM, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since V1 for both patches:
>         * corrected authorship email address (sorry for the noise!)
>
>  drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> index 8fc5d659e2dc01..8ca59b35595068 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> @@ -1508,7 +1508,7 @@ static const u16 pinmux_data[] = {
>  };
>
>  /*
> - * R8A7795 has 8 banks with 32 PGIOS in each => 256 GPIOs.
> + * R8A7795 has 8 banks with 32 GPIOs IN EACH => 256 GPIOs.

I don't think the capitalization of "in each" had to be changed?
(overzealous use of vim ~?)

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in sh-pfc-for-v4.15 with the above fixed, and once more
after filtering through s/r8a7795/r8a7795-es1/g.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wolfram Sang Oct. 11, 2017, 12:13 p.m. | #2
> > - * R8A7795 has 8 banks with 32 PGIOS in each => 256 GPIOs.
> > + * R8A7795 has 8 banks with 32 GPIOs IN EACH => 256 GPIOs.
> 
> I don't think the capitalization of "in each" had to be changed?
> (overzealous use of vim ~?)

Huh, how did this slip through? Sorry, Geert, and thanks for updating
it.

> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in sh-pfc-for-v4.15 with the above fixed, and once more
> after filtering through s/r8a7795/r8a7795-es1/g.

Good. I got the idea of checking es1 yesterday on the train, too, but
didn't come around to do it yet.

Thanks,

   Wolfram

Patch

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 8fc5d659e2dc01..8ca59b35595068 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -1508,7 +1508,7 @@  static const u16 pinmux_data[] = {
 };
 
 /*
- * R8A7795 has 8 banks with 32 PGIOS in each => 256 GPIOs.
+ * R8A7795 has 8 banks with 32 GPIOs IN EACH => 256 GPIOs.
  * Physical layout rows: A - AW, cols: 1 - 39.
  */
 #define ROW_GROUP_A(r) ('Z' - 'A' + 1 + (r))