From patchwork Tue Feb 8 12:24:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 82306 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9BF4DB70CD for ; Tue, 8 Feb 2011 23:25:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753646Ab1BHMYv (ORCPT ); Tue, 8 Feb 2011 07:24:51 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:48060 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775Ab1BHMYt (ORCPT ); Tue, 8 Feb 2011 07:24:49 -0500 Received: by mail-ey0-f174.google.com with SMTP id 27so2880337eye.19 for ; Tue, 08 Feb 2011 04:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:date:message-id:in-reply-to :references:subject; bh=zLvDx8VBJ5z29rqFSWMTwJlrka3Vu8JAn9lo/rHOQbA=; b=UuQgfx3d0tuu5aySyVX3P99tTwwMXeeo4NKHl2p2WADUVT4MZtQ7P9oofkqLyaTX9X GJgEo3vh4fJbWBpZ2zzCoR3/yil0ePS5JYAwvmkg97fSOfk5ArO2RbOMJIAckstKCpAG /izAUDOx/XKKqK6BixEUIMI1KBpchcYBIToz0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:date:message-id:in-reply-to:references:subject; b=ABBUaQxInoh7J29rCt5Kio7xpZugB852hxRh21OIrsuUBZaS4zJfEmgwI/WWrhxxyw vN8laKCCd5TCc9hqf1Sd+L1WH4RlnMF60jfOmxCUyFCVYi2q8GP/PYrw/peTbVFs5pOL ixnnclpNgU1tkc8EtPWgcbPEvAW3TEcQkI464= Received: by 10.213.27.202 with SMTP id j10mr5581763ebc.49.1297167888491; Tue, 08 Feb 2011 04:24:48 -0800 (PST) Received: from linux-mhg7.site (89-74-121-163.dynamic.chello.pl [89.74.121.163]) by mx.google.com with ESMTPS id t5sm3960418eeh.20.2011.02.08.04.24.46 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 08 Feb 2011 04:24:47 -0800 (PST) From: Bartlomiej Zolnierkiewicz To: linux-ide@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Date: Tue, 08 Feb 2011 13:24:38 +0100 Message-Id: <20110208122438.19110.37982.sendpatchset@linux-mhg7.site> In-Reply-To: <20110208122314.19110.4092.sendpatchset@linux-mhg7.site> References: <20110208122314.19110.4092.sendpatchset@linux-mhg7.site> Subject: [PATCH 09/20] pata_oldpiix: unify code for programming PIO and MWDMA timings Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From 30f6c60ad1e2f9c640352b74279fdf8a930847bf Mon Sep 17 00:00:00 2001 From: Bartlomiej Zolnierkiewicz Date: Tue, 8 Feb 2011 12:39:26 +0100 Subject: [PATCH 09/20] pata_oldpiix: unify code for programming PIO and MWDMA timings Besides making things noticably simpler it results in ~12% decrease in the driver LOC count and also ~5% decrease in the driver binary size (as measured on x86-32). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ata/pata_oldpiix.c | 88 +++++++++++++------------------------------ 1 files changed, 27 insertions(+), 61 deletions(-) diff --git a/drivers/ata/pata_oldpiix.c b/drivers/ata/pata_oldpiix.c index b811c16..433d2fc 100644 --- a/drivers/ata/pata_oldpiix.c +++ b/drivers/ata/pata_oldpiix.c @@ -50,20 +50,9 @@ static int oldpiix_pre_reset(struct ata_link *link, unsigned long deadline) return ata_sff_prereset(link, deadline); } -/** - * oldpiix_set_piomode - Initialize host controller PATA PIO timings - * @ap: Port whose timings we are configuring - * @adev: Device whose timings we are configuring - * - * Set PIO mode for device, in host controller PCI config space. - * - * LOCKING: - * None (inherited from caller). - */ - -static void oldpiix_set_piomode (struct ata_port *ap, struct ata_device *adev) +static void oldpiix_set_timings(struct ata_port *ap, struct ata_device *adev, + u8 pio, bool use_mwdma) { - unsigned int pio = adev->pio_mode - XFER_PIO_0; struct pci_dev *dev = to_pci_dev(ap->host->dev); unsigned int idetm_port= ap->port_no ? 0x42 : 0x40; u16 idetm_data; @@ -82,14 +71,18 @@ static void oldpiix_set_piomode (struct ata_port *ap, struct ata_device *adev) { 2, 1 }, { 2, 3 }, }; - if (pio > 1) + if (pio > 1 || use_mwdma) control |= 1; /* TIME */ - if (ata_pio_need_iordy(adev)) + if (ata_pio_need_iordy(adev) || use_mwdma) control |= 2; /* IE */ - /* Intel specifies that the prefetch/posting is for disk only */ if (adev->class == ATA_DEV_ATA) control |= 4; /* PPE */ + /* If the drive MWDMA is faster than it can do PIO then + we must force PIO into PIO0 */ + if (use_mwdma && adev->pio_mode < (XFER_PIO_0 + pio)) + /* Enable DMA timing only */ + control |= 8; /* PIO cycles in PIO0 */ pci_read_config_word(dev, idetm_port, &idetm_data); @@ -113,6 +106,22 @@ static void oldpiix_set_piomode (struct ata_port *ap, struct ata_device *adev) } /** + * oldpiix_set_piomode - Initialize host controller PATA PIO timings + * @ap: Port whose timings we are configuring + * @adev: Device whose timings we are configuring + * + * Set PIO mode for device, in host controller PCI config space. + * + * LOCKING: + * None (inherited from caller). + */ + +static void oldpiix_set_piomode(struct ata_port *ap, struct ata_device *adev) +{ + oldpiix_set_timings(ap, adev, adev->pio_mode - XFER_PIO_0, 0); +} + +/** * oldpiix_set_dmamode - Initialize host controller PATA DMA timings * @ap: Port whose timings we are configuring * @adev: Device to program @@ -125,58 +134,15 @@ static void oldpiix_set_piomode (struct ata_port *ap, struct ata_device *adev) static void oldpiix_set_dmamode (struct ata_port *ap, struct ata_device *adev) { - struct pci_dev *dev = to_pci_dev(ap->host->dev); - u8 idetm_port = ap->port_no ? 0x42 : 0x40; - u16 idetm_data; - - static const /* ISP RTC */ - u8 timings[][2] = { { 0, 0 }, - { 0, 0 }, - { 1, 0 }, - { 2, 1 }, - { 2, 3 }, }; - - /* - * MWDMA is driven by the PIO timings. We must also enable - * IORDY unconditionally along with TIME1. PPE has already - * been set when the PIO timing was set. - */ + /* MWDMA is driven by the PIO timings. */ unsigned int mwdma = adev->dma_mode - XFER_MW_DMA_0; - unsigned int control; const unsigned int needed_pio[3] = { XFER_PIO_0, XFER_PIO_3, XFER_PIO_4 }; int pio = needed_pio[mwdma] - XFER_PIO_0; - pci_read_config_word(dev, idetm_port, &idetm_data); - - control = 3; /* IORDY|TIME0 */ - /* Intel specifies that the PPE functionality is for disk only */ - if (adev->class == ATA_DEV_ATA) - control |= 4; /* PPE enable */ - - /* If the drive MWDMA is faster than it can do PIO then - we must force PIO into PIO0 */ - - if (adev->pio_mode < needed_pio[mwdma]) - /* Enable DMA timing only */ - control |= 8; /* PIO cycles in PIO0 */ - - /* Mask out the relevant control and timing bits we will load. Also - clear the other drive TIME register as a precaution */ - if (adev->devno == 0) { - idetm_data &= 0xCCE0; - idetm_data |= control; - } else { - idetm_data &= 0xCC0E; - idetm_data |= (control << 4); - } - idetm_data |= (timings[pio][0] << 12) | (timings[pio][1] << 8); - pci_write_config_word(dev, idetm_port, idetm_data); - - /* Track which port is configured */ - ap->private_data = adev; + oldpiix_set_timings(ap, adev, pio, 1); } /**