diff mbox series

[PULL,22/54] hw/block/onenand: Remove dead code block

Message ID	20171006155422.10135-23-kwolf@redhat.com
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CD5D9C047B70 From: Kevin Wolf <kwolf@redhat.com> To: qemu-block@nongnu.org Date: Fri, 6 Oct 2017 17:53:50 +0200 Message-Id: <20171006155422.10135-23-kwolf@redhat.com> In-Reply-To: <20171006155422.10135-1-kwolf@redhat.com> References: <20171006155422.10135-1-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 22/54] hw/block/onenand: Remove dead code block Precedence: list Cc: kwolf@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	[PULL,01/54] block: Typo fix in copy_on_readv() \| expand [PULL,01/54] block: Typo fix in copy_on_readv() [PULL,02/54] block: Make bdrv_img_create() size selection easier to read [PULL,03/54] hbitmap: Rename serialization_granularity to serialization_align [PULL,04/54] qcow2: Ensure bitmap serialization is aligned [PULL,05/54] dirty-bitmap: Drop unused functions [PULL,06/54] dirty-bitmap: Avoid size query failure during truncate [PULL,07/54] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes [PULL,08/54] dirty-bitmap: Track bitmap size by bytes [PULL,09/54] dirty-bitmap: Change bdrv_dirty_bitmap_serialize() to take bytes [PULL,10/54] qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based [PULL,11/54] dirty-bitmap: Set iterator start by offset, not sector [PULL,12/54] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset [PULL,13/54] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes [PULL,14/54] dirty-bitmap: Change bdrv_get_dirty_locked() to take bytes [PULL,15/54] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes [PULL,16/54] mirror: Switch mirror_dirty_init() to byte-based iteration [PULL,17/54] qcow2: Switch qcow2_measure() to byte-based iteration [PULL,18/54] qcow2: Switch load_bitmap_data() to byte-based iteration [PULL,19/54] qcow2: Switch store_bitmap_data() to byte-based iteration [PULL,20/54] dirty-bitmap: Switch bdrv_set_dirty() to bytes [PULL,21/54] dirty-bitmap: Convert internal hbitmap size/granularity [PULL,22/54] hw/block/onenand: Remove dead code block [PULL,23/54] qemu-iotests: remove dead code [PULL,24/54] qemu-iotests: get rid of AWK_PROG [PULL,25/54] qemu-iotests: move "check" code out of common.rc [PULL,26/54] qemu-iotests: cleanup and fix search for programs [PULL,27/54] qemu-iotests: limit non-_PROG-suffixed variables to common.rc [PULL,28/54] qemu-iotests: do not include common.rc in "check" [PULL,29/54] qemu-iotests: disintegrate more parts of common.config [PULL,30/54] qemu-iotests: fix uninitialized variable [PULL,31/54] qemu-iotests: get rid of $iam [PULL,32/54] qemu-iotests: merge "check" and "common" [PULL,33/54] block: Introduce BdrvChildRole.update_filename [PULL,34/54] commit: Support multiple roots above top node [PULL,35/54] qemu-iotests: Allow QMP pretty printing in common.qemu [PULL,36/54] qemu-iotests: Test commit block job where top has two parents [PULL,37/54] commit: Remove overlay_bs [PULL,38/54] qemu-io: Add -C for opening with copy-on-read [PULL,39/54] block: Uniform handling of 0-length bdrv_get_block_status() [PULL,40/54] iotests: Restore stty settings on completion [PULL,41/54] block: Add blkdebug hook for copy-on-read [PULL,42/54] block: Perform copy-on-read in loop [PULL,43/54] iotests: Add test 197 for covering copy-on-read [PULL,44/54] block: use 1 MB bounce buffers for crypto instead of 16KB [PULL,45/54] crypto: expose encryption sector size in APIs [PULL,46/54] block: fix data type casting for crypto payload offset [PULL,47/54] block: convert crypto driver to bdrv_co_preadv\|pwritev [PULL,48/54] block: convert qcrypto_block_encrypt\|decrypt to take bytes offset [PULL,49/54] block: support passthrough of BDRV_REQ_FUA in crypto driver [PULL,50/54] block/mirror: check backing in bdrv_mirror_top_refresh_filename [PULL,51/54] iotests: Fix 195 if IMGFMT is part of TEST_DIR [PULL,52/54] qcow2: fix return error code in qcow2_truncate() [PULL,53/54] qcow2: truncate the tail of the image file after shrinking the image [PULL,54/54] block/mirror: check backing in bdrv_mirror_top_flush

Commit Message

Kevin Wolf Oct. 6, 2017, 3:53 p.m. UTC

From: Thomas Huth <thuth@redhat.com>

The condition of the for-loop makes sure that b is always smaller
than s->blocks, so the "if (b >= s->blocks)" statement is completely
superfluous here.

Buglink: https://bugs.launchpad.net/qemu/+bug/1715007
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/block/onenand.c | 4 ----
 1 file changed, 4 deletions(-)

diff mbox series

Patch

diff --git a/hw/block/onenand.c b/hw/block/onenand.c
index 30e40f3914..de65c9ebb9 100644
--- a/hw/block/onenand.c
+++ b/hw/block/onenand.c
@@ -520,10 +520,6 @@  static void onenand_command(OneNANDState *s)
         s->intstatus |= ONEN_INT;
 
         for (b = 0; b < s->blocks; b ++) {
-            if (b >= s->blocks) {
-                s->status |= ONEN_ERR_CMD;
-                break;
-            }
             if (s->blockwp[b] == ONEN_LOCK_LOCKTIGHTEN)
                 break;