| Message ID | 1507262670-12849-1-git-send-email-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | acpi: sync up _BIX test in method to acpi_battery tests | expand |
On 06/10/17 05:04, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/method/method.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index 6b023ac..b5484d7 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -4165,14 +4165,19 @@ static void method_test_BIX_return( > obj->Package.Elements[7].Integer.Value); > failed = true; > } > - /* Cycle Count */ > - if (obj->Package.Elements[8].Integer.Value > 0x7fffffff) { > - fwts_failed(fw, LOG_LEVEL_LOW, "Method_BIXCyleCount", > - "%s: %s (Element 8) is unknown: " > - "0x%8.8" PRIx64 ".", Elements[8].name, > - name, obj->Package.Elements[8].Integer.Value); > + /* Cycle Count: value = 0 ~ 0xFFFFFFFE or 0xFFFFFFFF (unknown) */ > + > + /* Measurement Accuracy */ > + if (obj->Package.Elements[9].Integer.Value > 100000) { > + fwts_failed(fw, LOG_LEVEL_CRITICAL, > + "Method_BIXMeasurementAccuracy", > + "%s: %s (Element 9) " > + "is unknown: 0x%8.8" PRIx64 ".", > + name, elements[9].name, > + obj->Package.Elements[9].Integer.Value); > failed = true; > } > + > #endif > if (failed) > fwts_advice(fw, > Acked-by: Colin Ian King <colin.king@canonical.com>
On 10/06/2017 12:04 PM, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/method/method.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index 6b023ac..b5484d7 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -4165,14 +4165,19 @@ static void method_test_BIX_return( > obj->Package.Elements[7].Integer.Value); > failed = true; > } > - /* Cycle Count */ > - if (obj->Package.Elements[8].Integer.Value > 0x7fffffff) { > - fwts_failed(fw, LOG_LEVEL_LOW, "Method_BIXCyleCount", > - "%s: %s (Element 8) is unknown: " > - "0x%8.8" PRIx64 ".", Elements[8].name, > - name, obj->Package.Elements[8].Integer.Value); > + /* Cycle Count: value = 0 ~ 0xFFFFFFFE or 0xFFFFFFFF (unknown) */ > + > + /* Measurement Accuracy */ > + if (obj->Package.Elements[9].Integer.Value > 100000) { > + fwts_failed(fw, LOG_LEVEL_CRITICAL, > + "Method_BIXMeasurementAccuracy", > + "%s: %s (Element 9) " > + "is unknown: 0x%8.8" PRIx64 ".", > + name, elements[9].name, > + obj->Package.Elements[9].Integer.Value); > failed = true; > } > + > #endif > if (failed) > fwts_advice(fw, > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index 6b023ac..b5484d7 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -4165,14 +4165,19 @@ static void method_test_BIX_return( obj->Package.Elements[7].Integer.Value); failed = true; } - /* Cycle Count */ - if (obj->Package.Elements[8].Integer.Value > 0x7fffffff) { - fwts_failed(fw, LOG_LEVEL_LOW, "Method_BIXCyleCount", - "%s: %s (Element 8) is unknown: " - "0x%8.8" PRIx64 ".", Elements[8].name, - name, obj->Package.Elements[8].Integer.Value); + /* Cycle Count: value = 0 ~ 0xFFFFFFFE or 0xFFFFFFFF (unknown) */ + + /* Measurement Accuracy */ + if (obj->Package.Elements[9].Integer.Value > 100000) { + fwts_failed(fw, LOG_LEVEL_CRITICAL, + "Method_BIXMeasurementAccuracy", + "%s: %s (Element 9) " + "is unknown: 0x%8.8" PRIx64 ".", + name, elements[9].name, + obj->Package.Elements[9].Integer.Value); failed = true; } + #endif if (failed) fwts_advice(fw,
Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/acpi/method/method.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)