From patchwork Thu Oct 5 20:51:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 822066 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y7Q3C1htgz9s7p for ; Fri, 6 Oct 2017 07:53:27 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3y7Q3B6JrBzDr6N for ; Fri, 6 Oct 2017 07:53:26 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=217.72.192.78; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3y7Q0x5cQHzDqpD for ; Fri, 6 Oct 2017 07:51:29 +1100 (AEDT) Received: from [192.168.1.2] ([77.181.51.69]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LzKIP-1dE2Jn0snx-014Tkp; Thu, 05 Oct 2017 22:51:14 +0200 Subject: [PATCH 1/2] powermac: Delete an error message for a failed memory allocation in kw_i2c_host_init() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras References: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Message-ID: <5dc8fe2f-0459-faff-585f-a92137115895@users.sourceforge.net> Date: Thu, 5 Oct 2017 22:51:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:u2ew0EXdCdtBPETkmvm/h1+JMFqTyElBjTeBUhqO3WRuk3L3sN2 rb69rGOs/BzvpBdDNuTzQwJhjp5J9ea+OqJ6nqYsFiZIzeZ0yPYNgNROo5jvbuaae3cF5Ql 1T+2ThWB38IUrHbomTIqsvB34g6B9JAuga6BVv0AfuaXGO7jZ+aDELjk4CJf4VpmL7oYqbo WBZJHBFBo2HYsjMYFSu+A== X-UI-Out-Filterresults: notjunk:1; V01:K0:sU2KmK2PZtk=:/10q04rX/5cuxDJDPZgJhI csLW2SI/g1UXIvj/KcZMFGjRyOJlmmrEkczOsnHfmg/STedbq138vNTsqVnL6IDABamjkZNjl k2rZSjyJoLv/hrGgD10wXSVjyIOmQpH673nqIJDezUO9mbZadQQSWsTxcgaTpqhgvKRWzidN/ BsokXZRx+ttP9zpbzUJN5QVOZXELSExgEPt5oEujqDtJwWoHyIlsAC9h6lNNTWF2fujhJmc1h DjX3h4q0ex8eIJl1xKcyulO9zO+dIrU4yDEoJ6NQKXSGCp+MWyUJaH5JIfAbyjw6GK3hQ7lA6 pPmA8GDDYOaRY3TmQGDwUlIKzlOqXr93GmCnThYy4S26P/8qMOofhXdxckHm7+Ii3Yj3isIsQ Puqhhx+P/AStusPmpLBs9V+E9hN+AuUWwjtEkBV3kx5Pj5bfhaHBqFBVx2VzLZoN2CjzEN+By I8Q4VhY3ALLo8JIz7I4UyKIPaQCst/nU0cSebyWFVgqMH9hPwXoPtvevRydAZD8J9QnlE0qCb QOYlREx2xRqHVFnnilCGJDD7AMNJRpL6vZ2fB9HSI/HMpYQ0db1o72k+QGeqgW2bEsvTzJSmL wEYjsdGtvOgWNDhIQeoLAkxzAXrRHB14VpCx6gS9rjRinZA7VjmtX4TPU8op7P36div2HdVnp JV5CLU/g928v4WfmH8ZshocaOX/guGvMFyqTHphhAWePQCjqrnYQ3viIufY5GTLv506WM3sP3 TGFXL7oth0Pytd/dFyH4BMeUjsE6R61H9b3Bzy++I0s9ABvl0xj764NmBLrGQYWNLJLy0FcuM OWO7XT9ckKKv1BorBiSTTLNR9t6UqL7oIT9sPSxxDNYzstOY9c= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 5 Oct 2017 22:30:29 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/powermac/low_i2c.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c index 70183eb3d5c8..ecd166b5549b 100644 --- a/arch/powerpc/platforms/powermac/low_i2c.c +++ b/arch/powerpc/platforms/powermac/low_i2c.c @@ -493,11 +493,8 @@ static struct pmac_i2c_host_kw *__init kw_i2c_host_init(struct device_node *np) u32 steps; host = kzalloc(sizeof(struct pmac_i2c_host_kw), GFP_KERNEL); - if (host == NULL) { - printk(KERN_ERR "low_i2c: Can't allocate host for %pOF\n", - np); + if (!host) return NULL; - } /* Apple is kind enough to provide a valid AAPL,address property * on all i2c keywest nodes so far ... we would have to fallback