mtd: nand: atmel: Actually use the PM ops

Message ID 20171005165724.30516-1-boris.brezillon@free-electrons.com
State Accepted
Delegated to: Boris Brezillon
Headers show
Series
  • mtd: nand: atmel: Actually use the PM ops
Related show

Commit Message

Boris Brezillon Oct. 5, 2017, 4:57 p.m.
commit 6e532afaca8e ("mtd: nand: atmel: Add PM ops") was defining PM
ops but nothing was using/referencing those PM ops.

Fixes: 6e532afaca8e ("mtd: nand: atmel: Add PM ops")
Cc: <stable@vger.kernel.org>
Cc: Romain Izard <romain.izard.pro@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 drivers/mtd/nand/atmel/nand-controller.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Wenyou Yang Oct. 9, 2017, 3:09 a.m. | #1
On 2017/10/6 0:57, Boris Brezillon wrote:
> commit 6e532afaca8e ("mtd: nand: atmel: Add PM ops") was defining PM
> ops but nothing was using/referencing those PM ops.
>
> Fixes: 6e532afaca8e ("mtd: nand: atmel: Add PM ops")
> Cc: <stable@vger.kernel.org>
> Cc: Romain Izard <romain.izard.pro@gmail.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
>   drivers/mtd/nand/atmel/nand-controller.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> index 29182160bb5f..90a71a56bc23 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -2549,6 +2549,7 @@ static struct platform_driver atmel_nand_controller_driver = {
>   	.driver = {
>   		.name = "atmel-nand-controller",
>   		.of_match_table = of_match_ptr(atmel_nand_controller_of_ids),
> +		.pm = &atmel_nand_controller_pm_ops,
>   	},
>   	.probe = atmel_nand_controller_probe,
>   	.remove = atmel_nand_controller_remove,

Acked-by: Wenyou Yang <wenyou.yang@microchip.com>
Romain Izard Oct. 11, 2017, 8:28 a.m. | #2
2017-10-05 18:57 GMT+02:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> commit 6e532afaca8e ("mtd: nand: atmel: Add PM ops") was defining PM
> ops but nothing was using/referencing those PM ops.
>
> Fixes: 6e532afaca8e ("mtd: nand: atmel: Add PM ops")
> Cc: <stable@vger.kernel.org>
> Cc: Romain Izard <romain.izard.pro@gmail.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Tested-by: Romain Izard <romain.izard.pro@gmail.com>

> ---
>  drivers/mtd/nand/atmel/nand-controller.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> index 29182160bb5f..90a71a56bc23 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -2549,6 +2549,7 @@ static struct platform_driver atmel_nand_controller_driver = {
>         .driver = {
>                 .name = "atmel-nand-controller",
>                 .of_match_table = of_match_ptr(atmel_nand_controller_of_ids),
> +               .pm = &atmel_nand_controller_pm_ops,
>         },
>         .probe = atmel_nand_controller_probe,
>         .remove = atmel_nand_controller_remove,
> --
> 2.11.0
>
Boris Brezillon Oct. 14, 2017, 3:12 p.m. | #3
On Thu,  5 Oct 2017 18:57:24 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> commit 6e532afaca8e ("mtd: nand: atmel: Add PM ops") was defining PM
> ops but nothing was using/referencing those PM ops.
> 

Applied.

> Fixes: 6e532afaca8e ("mtd: nand: atmel: Add PM ops")
> Cc: <stable@vger.kernel.org>
> Cc: Romain Izard <romain.izard.pro@gmail.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
>  drivers/mtd/nand/atmel/nand-controller.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> index 29182160bb5f..90a71a56bc23 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -2549,6 +2549,7 @@ static struct platform_driver atmel_nand_controller_driver = {
>  	.driver = {
>  		.name = "atmel-nand-controller",
>  		.of_match_table = of_match_ptr(atmel_nand_controller_of_ids),
> +		.pm = &atmel_nand_controller_pm_ops,
>  	},
>  	.probe = atmel_nand_controller_probe,
>  	.remove = atmel_nand_controller_remove,

Patch

diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
index 29182160bb5f..90a71a56bc23 100644
--- a/drivers/mtd/nand/atmel/nand-controller.c
+++ b/drivers/mtd/nand/atmel/nand-controller.c
@@ -2549,6 +2549,7 @@  static struct platform_driver atmel_nand_controller_driver = {
 	.driver = {
 		.name = "atmel-nand-controller",
 		.of_match_table = of_match_ptr(atmel_nand_controller_of_ids),
+		.pm = &atmel_nand_controller_pm_ops,
 	},
 	.probe = atmel_nand_controller_probe,
 	.remove = atmel_nand_controller_remove,