diff mbox series

[U-Boot,2/2] mx6: sys_proto: Add prototypes for imx6_pcie_toggle() functions

Message ID 1507205758-16195-2-git-send-email-diego.dorta@nxp.com
State Accepted
Commit e2000731ae5396d97bae44c404e63d5f7b6e4788
Delegated to: Stefano Babic
Headers show
Series [U-Boot,1/2] mx6: clock: Add a prototype for do_mx6_showclocks() | expand

Commit Message

Diego Dorta Oct. 5, 2017, 12:15 p.m. UTC
When compiling with W=1 errors are observed:

drivers/pci/pcie_imx.c:517:12: warning: no previous prototype for ‘imx6_pcie_toggle_power’ [-Wmissing-prototypes] __weak int imx6_pcie_toggle_power(void)

drivers/pci/pcie_imx.c:528:12: warning: no previous prototype for ‘imx6_pcie_toggle_reset’ [-Wmissing-prototypes] __weak int imx6_pcie_toggle_reset(void)

Remove these warnings by adding the functions prototypes on arch-mx6/sys_proto.

Signed-off-by: Diego Dorta <diego.dorta@nxp.com>
---
 arch/arm/include/asm/arch-mx6/sys_proto.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Stefano Babic Oct. 12, 2017, 4:22 p.m. UTC | #1
On 05/10/2017 14:15, Diego Dorta wrote:
> When compiling with W=1 errors are observed:
> 
> drivers/pci/pcie_imx.c:517:12: warning: no previous prototype for ‘imx6_pcie_toggle_power’ [-Wmissing-prototypes] __weak int imx6_pcie_toggle_power(void)
> 
> drivers/pci/pcie_imx.c:528:12: warning: no previous prototype for ‘imx6_pcie_toggle_reset’ [-Wmissing-prototypes] __weak int imx6_pcie_toggle_reset(void)
> 
> Remove these warnings by adding the functions prototypes on arch-mx6/sys_proto.
> 
> Signed-off-by: Diego Dorta <diego.dorta@nxp.com>
> ---
>  arch/arm/include/asm/arch-mx6/sys_proto.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h
> index ba73943..b22a7a0 100644
> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
> @@ -13,3 +13,6 @@
>  
>  #define is_usbotg_phy_active(void) (!(readl(USB_PHY0_BASE_ADDR + USBPHY_PWD) & \
>  				   USBPHY_PWD_RXPWDRX))
> +
> +int imx6_pcie_toggle_power(void);
> +int imx6_pcie_toggle_reset(void);
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h
index ba73943..b22a7a0 100644
--- a/arch/arm/include/asm/arch-mx6/sys_proto.h
+++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
@@ -13,3 +13,6 @@ 
 
 #define is_usbotg_phy_active(void) (!(readl(USB_PHY0_BASE_ADDR + USBPHY_PWD) & \
 				   USBPHY_PWD_RXPWDRX))
+
+int imx6_pcie_toggle_power(void);
+int imx6_pcie_toggle_reset(void);