dt-bindings: pinctrl: Move mcp23s08 from gpio

Message ID 20171005075002.9901-1-poeschel@lemonage.de
State New
Headers show
Series
  • dt-bindings: pinctrl: Move mcp23s08 from gpio
Related show

Commit Message

Lars Poeschel Oct. 5, 2017, 7:50 a.m.
The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
devicetree binding doc as well. So driver and binding doc are in sync
again.

Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
---
 .../bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt}     | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt} (100%)

Comments

Linus Walleij Oct. 7, 2017, 11:58 p.m. | #1
On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel@lemonage.de> wrote:

> The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> devicetree binding doc as well. So driver and binding doc are in sync
> again.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>

Are there no new references to the generic pin control binding
needed as well?

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lars Poeschel Oct. 9, 2017, 9:39 a.m. | #2
On Sun, Oct 8, 2017 at 01:58:52 CEST Linus Walleij wrote:

CCing-in Sebastian Reichel who did the move to pinctrl and pinctrl support as 
well.

> On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel@lemonage.de> wrote:
> > The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> > devicetree binding doc as well. So driver and binding doc are in sync
> > again.
> > 
> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> 
> Are there no new references to the generic pin control binding
> needed as well?

Well, yes there is one: As far as I can see it supports the bias-pull-up 
property.
My first intention was to have the doc as we have it in the right place, but 
you are right: It needs an update as well. I can do this, but Sebastian, 
please keep an eye on that.

As there are already patches depending on this patch (https://marc.info/?
l=linux-gpio&m=150726650325394&w=4) I would suggest, that you pull in this 
patch as is and I do the little update on the doc as a seperate patch.

Regards,
Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sebastian Reichel Oct. 9, 2017, 10:29 a.m. | #3
Hi,

On Thu, Oct 05, 2017 at 09:50:02AM +0200, Lars Poeschel wrote:
> The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> devicetree binding doc as well. So driver and binding doc are in sync
> again.
> 
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> ---
>  .../bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt}     | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename Documentation/devicetree/bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt} (100%)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt
> rename to Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian
Sebastian Reichel Oct. 9, 2017, 10:33 a.m. | #4
Hi,

On Mon, Oct 09, 2017 at 11:39:02AM +0200, Lars Poeschel wrote:
> On Sun, Oct 8, 2017 at 01:58:52 CEST Linus Walleij wrote:
> 
> CCing-in Sebastian Reichel who did the move to pinctrl and pinctrl support as 
> well.
> 
> > On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel@lemonage.de> wrote:
> > > The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> > > devicetree binding doc as well. So driver and binding doc are in sync
> > > again.
> > > 
> > > Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> > 
> > Are there no new references to the generic pin control binding
> > needed as well?
> 
> Well, yes there is one: As far as I can see it supports the bias-pull-up 
> property.
> My first intention was to have the doc as we have it in the right place, but 
> you are right: It needs an update as well. I can do this, but Sebastian, 
> please keep an eye on that.
> 
> As there are already patches depending on this patch (https://marc.info/?
> l=linux-gpio&m=150726650325394&w=4) I would suggest, that you pull in this 
> patch as is and I do the little update on the doc as a seperate patch.

Yes, the driver supports being used as pin controller with the
"bias-pull-up;" property now. For example I use this with a RPi
to enable pull-ups for all pins:

gpio21: gpio@21 {
        compatible = "microchip,mcp23017";
        gpio-controller;
        #gpio-cells = <0x2>;
        reg = <0x21>;
        interrupt-parent = <&socgpio>;
        interrupts = <0x17 0x8>;
        interrupt-names = "mcp23017@21 irq";
        interrupt-controller;
        #interrupt-cells = <0x2>;
        microchip,irq-mirror;
        pinctrl-names = "default";
        pinctrl-0 = <&i2cgpio0irq &gpio21pullups>;

        gpio21pullups: pinmux {
                pins = "gpio0", "gpio1", "gpio2", "gpio3",
                       "gpio4", "gpio5", "gpio6", "gpio7",
                       "gpio8", "gpio9", "gpio10", "gpio11",
                       "gpio12", "gpio13", "gpio14", "gpio15";
                bias-pull-up;
        };  
};

-- Sebastian
Linus Walleij Oct. 11, 2017, 8:01 a.m. | #5
On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel@lemonage.de> wrote:

> The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> devicetree binding doc as well. So driver and binding doc are in sync
> again.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>

Patch applied with Sebastian's tag.

Nothing controversial about this so why not.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
similarity index 100%
rename from Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt
rename to Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt