| Message ID | 1507166615-4530-2-git-send-email-preid@electromag.com.au |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: mcp32s08: add support for mcp23018 | expand |
On Thu, Oct 5, 2017 at 3:23 AM, Phil Reid <preid@electromag.com.au> wrote: > This adds the required definitions for the mcp23018 which is the i2c > variant of the mcp23s18. Which is logical if "s" stands for "SPI", "0" is normal or I2C. > - "microchip,mcp23s18" for 16 GPIO SPI version So that is the SPI version > - "microchip,mcp23008" for 8 GPIO I2C version or > - "microchip,mcp23017" for 16 GPIO I2C version of the chip > + - "microchip,mcp23018" for 16 GPIO SPI version And right here you say that this is also the SPI version, but the commit message says it is the I2C version. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 8/10/2017 07:41, Linus Walleij wrote: > On Thu, Oct 5, 2017 at 3:23 AM, Phil Reid <preid@electromag.com.au> wrote: > >> This adds the required definitions for the mcp23018 which is the i2c >> variant of the mcp23s18. > > Which is logical if "s" stands for "SPI", "0" is normal or I2C. > >> - "microchip,mcp23s18" for 16 GPIO SPI version > > So that is the SPI version > >> - "microchip,mcp23008" for 8 GPIO I2C version or >> - "microchip,mcp23017" for 16 GPIO I2C version of the chip >> + - "microchip,mcp23018" for 16 GPIO SPI version > > And right here you say that this is also the SPI version, but the > commit message says it is the I2C version. > G'day Linus, thanks for looking at this. Sorry, there's a v2 fixing that. Along with proposed patches for fixing the items raised in my RFI. Except for modelling the inverter. Not even sure how to approach that one.
diff --git a/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt b/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt index c934106..c0f495e 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt +++ b/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt @@ -13,6 +13,7 @@ Required properties: - "microchip,mcp23s18" for 16 GPIO SPI version - "microchip,mcp23008" for 8 GPIO I2C version or - "microchip,mcp23017" for 16 GPIO I2C version of the chip + - "microchip,mcp23018" for 16 GPIO SPI version NOTE: Do not use the old mcp prefix any more. It is deprecated and will be removed. - #gpio-cells : Should be two.
This adds the required definitions for the mcp23018 which is the i2c variant of the mcp23s18. Signed-off-by: Phil Reid <preid@electromag.com.au> --- Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt | 1 + 1 file changed, 1 insertion(+)