Message ID | 20171004152553.30263-3-mreitz@redhat.com |
---|---|
State | New |
Headers | show |
Series | block: Don't compare strings in bdrv_reopen_prepare() | expand |
On 10/04/2017 10:25 AM, Max Reitz wrote: > Besides the macro itself, this patch also adds a corresponding > Coccinelle rule. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > include/qapi/qmp/qlist.h | 3 +++ > scripts/coccinelle/qobject.cocci | 3 +++ > 2 files changed, 6 insertions(+) Reviewed-by: Eric Blake <eblake@redhat.com>
On Wed 04 Oct 2017 05:25:49 PM CEST, Max Reitz wrote: > Besides the macro itself, this patch also adds a corresponding > Coccinelle rule. > > Signed-off-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Alberto Garcia <berto@igalia.com> Berto
diff --git a/include/qapi/qmp/qlist.h b/include/qapi/qmp/qlist.h index c4b5fdad9b..59d209bbae 100644 --- a/include/qapi/qmp/qlist.h +++ b/include/qapi/qmp/qlist.h @@ -15,6 +15,7 @@ #include "qapi/qmp/qobject.h" #include "qapi/qmp/qnum.h" +#include "qapi/qmp/qnull.h" #include "qemu/queue.h" typedef struct QListEntry { @@ -37,6 +38,8 @@ typedef struct QList { qlist_append(qlist, qbool_from_bool(value)) #define qlist_append_str(qlist, value) \ qlist_append(qlist, qstring_from_str(value)) +#define qlist_append_null(qlist) \ + qlist_append(qlist, qnull()) #define QLIST_FOREACH_ENTRY(qlist, var) \ for ((var) = ((qlist)->head.tqh_first); \ diff --git a/scripts/coccinelle/qobject.cocci b/scripts/coccinelle/qobject.cocci index 1120eb1a42..47bcafe9a9 100644 --- a/scripts/coccinelle/qobject.cocci +++ b/scripts/coccinelle/qobject.cocci @@ -41,4 +41,7 @@ expression Obj, E; | - qlist_append(Obj, qstring_from_str(E)); + qlist_append_str(Obj, E); +| +- qlist_append(Obj, qnull()); ++ qlist_append_null(Obj); )
Besides the macro itself, this patch also adds a corresponding Coccinelle rule. Signed-off-by: Max Reitz <mreitz@redhat.com> --- include/qapi/qmp/qlist.h | 3 +++ scripts/coccinelle/qobject.cocci | 3 +++ 2 files changed, 6 insertions(+)