From patchwork Mon Feb 7 19:13:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 82124 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 15D8AB70A9 for ; Tue, 8 Feb 2011 06:13:18 +1100 (EST) Received: (qmail 20325 invoked by alias); 7 Feb 2011 19:13:17 -0000 Received: (qmail 20317 invoked by uid 22791); 7 Feb 2011 19:13:16 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Feb 2011 19:13:11 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p17JD97n031512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Feb 2011 14:13:10 -0500 Received: from vishnu.quesejoda.com (vpn-224-26.phx2.redhat.com [10.3.224.26]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p17JD9N6026641; Mon, 7 Feb 2011 14:13:09 -0500 Message-ID: <4D504445.9080606@redhat.com> Date: Mon, 07 Feb 2011 13:13:09 -0600 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 MIME-Version: 1.0 To: Richard Guenther CC: Richard Henderson , gcc-patches Subject: Re: [trans-mem] handle invisible references for decls (PR/47554) References: <4D4C5CC2.2060205@redhat.com> <4D4C61BE.9010805@redhat.com> In-Reply-To: Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org >> I sincerely believe that the test in aggregate_value_p is a mistake. >> We should not be lying about the fact that this value is a pointer. >> But looking at how DECL_BY_REFERENCE is used elsewhere, it'll be a >> hard one to unravel. And that certainly should not be done on this >> branch. > > Hm, I think we fixed this on trunk and DECL_BY_REFERENCE result-decls > are now even in SSA form. Thanks Richi. I have put a note on the source to double check the existence of this failure after the next (long over due) merge. Committed as obvious. Aldy * trans-mem.c (requires_barrier): Add comment. Index: trans-mem.c =================================================================== --- trans-mem.c (revision 169838) +++ trans-mem.c (working copy) @@ -1471,7 +1471,11 @@ requires_barrier (basic_block entry_bloc { /* ??? This value is a pointer, but aggregate_value_p has been jigged to return true which confuses needs_to_live_in_memory. - This ought to be cleaned up generically. */ + This ought to be cleaned up generically. + + FIXME: Verify this still happens after the next mainline + merge. Testcase ie g++.dg/tm/pr47554.C. + */ return false; }