| Message ID | 1507111682-66171-2-git-send-email-imammedo@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | add DEFINE_TYPES() helper to simplify batch type registration | expand |
On Wed, Oct 04, 2017 at 12:08:00PM +0200, Igor Mammedov wrote: > type_register()/type_register_static() functions in current impl. > can't fail returning 0, also none of the users check for error > so update doc comment to reflect current behaviour. > > Suggested-by: Eduardo Habkost <ehabkost@redhat.com> > Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> I'm queueing it on machine-next.
diff --git a/include/qom/object.h b/include/qom/object.h index f3e5cff..76a5e3a 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -773,7 +773,7 @@ const char *object_get_typename(const Object *obj); * @info and all of the strings it points to should exist for the life time * that the type is registered. * - * Returns: 0 on failure, the new #Type on success. + * Returns: the new #Type. */ Type type_register_static(const TypeInfo *info); @@ -784,7 +784,7 @@ Type type_register_static(const TypeInfo *info); * Unlike type_register_static(), this call does not require @info or its * string members to continue to exist after the call returns. * - * Returns: 0 on failure, the new #Type on success. + * Returns: the new #Type. */ Type type_register(const TypeInfo *info);
type_register()/type_register_static() functions in current impl. can't fail returning 0, also none of the users check for error so update doc comment to reflect current behaviour. Suggested-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Igor Mammedov <imammedo@redhat.com> --- include/qom/object.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)