From patchwork Tue Oct 3 22:48:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 821055 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-85325-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="qlq2bN1r"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y6DjX2nTgz9t2Z for ; Wed, 4 Oct 2017 09:49:04 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; q=dns; s=default; b=ehk7RtTf3PGi9hqHpagcZNz6zYtSv j6nJx68Q0+2ZTQrxWVb9G+xNub8NfkGNBAQv5GUcD+hNCNx/S6/yqihMaaA/vpde I6eRVfNrUeImWRE+bT+MvgNcAhQERshyNnHJnzKlaRnIOr9vcYEtHJyZdduFv+Wc 0Z+l25K6TfNgWo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; s=default; bh=4+8kk35eLl+GHbIRLEI8FKW/aPw=; b=qlq 2bN1rS5ZIn4rwuVpZJ3qQepBj5yKILrsAZOY2bBfTSHQZPD+yVMej30xgeZLxfkp L4U6ERhU4KOknVuVY8usKSpcJQMpLCnjg01HpH+IzWBm4DvoyZFs0qryuwa94Scf IZBoF32tOZEQ1h5GaIynO3O0GaEPkS8AKScOubxo= Received: (qmail 73306 invoked by alias); 3 Oct 2017 22:48:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 73294 invoked by uid 89); 3 Oct 2017 22:48:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:990 X-HELO: mail-oi0-f47.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=tH+X7sIU1RIQJS0FC0NUJ1v9qaCw2kdZtqp8Zkb6MAc=; b=VHUTj2Me1X6I92ds/rY6DAgbtGi7qbX9TjP50pLk4bzzc85A2XjqDfkeuwm9OY3JKz 47KvgOaGjCpgvNj5gQy0u9ixR9fyV/vK6clEqaxcqmy1eonRauQJq7AJLEMqi9tB3/Tp +C7XU3tithyw/1OTzQB9IAHCRg8xio45ZKGzJw3ETvbZBehwhdneICM3hU+DgiqX8jMw ITdjWSuNdnqIt3eqXpHDrmVMhEHADu84j41r51dyVIxXqkm8SjAO+0Xri1qh4arFIkL6 s/MqS/GNTRSDjr+jjliAFIOztVa2hkFBAgs+W83VdrMZ+Kqb87wy2cU8WzS8T+s7elxR dHmw== X-Gm-Message-State: AMCzsaUccEv7nWipwy6YzNTtpTR/gHsRd3qMn3svypL6L+dQu/CVRVuT CEe7h+xZbuAY5mXb0i13e2nvrXSI X-Google-Smtp-Source: AOwi7QAyKLKgo9fcdIydIpB+6RvdjE+a3nN+mFg5TKPzZGc6beECjMcNFqDGRlT6BMZJgbH2F2qw3Q== X-Received: by 10.202.98.4 with SMTP id w4mr8582609oib.378.1507070933572; Tue, 03 Oct 2017 15:48:53 -0700 (PDT) Date: Tue, 3 Oct 2017 15:48:47 -0700 From: "H.J. Lu" To: GNU C Library Subject: [PATCH] arm: Don't check _DYNAMIC in elf_machine_load_address Message-ID: <20171003224847.GA27187@gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.0 (2017-09-02) Since arm can't convert access _DYNAMIC via GOT, which needs dynamic relocation, to PC-relative at link-time, don't check _DYNAMIC in elf_machine_load_address. I am checking it in. H.J. * sysdeps/arm/dl-machine.h (elf_machine_load_address): Don't check _DYNAMIC. --- sysdeps/arm/dl-machine.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h index efe2e1b3a3..7e2d73e3d4 100644 --- a/sysdeps/arm/dl-machine.h +++ b/sysdeps/arm/dl-machine.h @@ -59,9 +59,6 @@ elf_machine_load_address (void) Elf32_Addr got_addr = (Elf32_Addr) &__dl_start; asm ("adr %0, _dl_start" : "=r" (pcrel_addr)); #else - extern Elf32_Dyn _DYNAMIC[] __attribute__((weak, visibility ("hidden"))); - if (!_DYNAMIC) - return 0; extern Elf32_Addr __dl_relocate_static_pie (void *) asm ("_dl_relocate_static_pie") attribute_hidden; Elf32_Addr got_addr = (Elf32_Addr) &__dl_relocate_static_pie;