| Message ID | 20171002141341.24616-2-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qapi: Cleanups around qapi2texi | expand |
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster <armbru@redhat.com> wrote: > Reported-by: Daniel P. Berrange <berrange@redhat.com> > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> (reviweing this patch makes me realize that the last expression/command in qapi-schema isn't in the generated doc..) > --- > qapi-schema.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index a9dd043f65..3490a5edaf 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3188,7 +3188,7 @@ > # > # Show Virtual Machine Generation ID > # > -# Since 2.9 > +# Since: 2.9 > ## > { 'command': 'query-vm-generation-id', 'returns': 'GuidInfo' } > > -- > 2.13.6 > >
Marc-André Lureau <marcandre.lureau@gmail.com> writes: > On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster <armbru@redhat.com> wrote: >> Reported-by: Daniel P. Berrange <berrange@redhat.com> >> Signed-off-by: Markus Armbruster <armbru@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Thanks! > (reviweing this patch makes me realize that the last > expression/command in qapi-schema isn't in the generated doc..) Oh. We better fix that.
Hi On Wed, Oct 4, 2017 at 3:03 PM, Markus Armbruster <armbru@redhat.com> wrote: > Marc-André Lureau <marcandre.lureau@gmail.com> writes: > >> On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster <armbru@redhat.com> wrote: >>> Reported-by: Daniel P. Berrange <berrange@redhat.com> >>> Signed-off-by: Markus Armbruster <armbru@redhat.com> >> >> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > > Thanks! > >> (reviweing this patch makes me realize that the last >> expression/command in qapi-schema isn't in the generated doc..) > > Oh. We better fix that. Ah no, it's because I had an old docs/qemu-qmp-qapi.texi in my build tree...
diff --git a/qapi-schema.json b/qapi-schema.json index a9dd043f65..3490a5edaf 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3188,7 +3188,7 @@ # # Show Virtual Machine Generation ID # -# Since 2.9 +# Since: 2.9 ## { 'command': 'query-vm-generation-id', 'returns': 'GuidInfo' }
Reported-by: Daniel P. Berrange <berrange@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)