| Message ID | 20171002141341.24616-7-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qapi: Cleanups around qapi2texi | expand |
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster <armbru@redhat.com> wrote: > Repurposing the function parameter doc for stepping through > doc.sections.__str__() is not nice. Use new variable @text instead. > > While there, eliminate variables name and func. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > scripts/qapi2texi.py | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py > index a317526e51..f876d9a174 100755 > --- a/scripts/qapi2texi.py > +++ b/scripts/qapi2texi.py > @@ -180,16 +180,14 @@ def texi_sections(doc): > """Format additional sections following arguments""" > body = '' > for section in doc.sections: > - name, doc = (section.name, str(section)) > - func = texi_format > - if name.startswith('Example'): > - func = texi_example > - > - if name: > + if section.name: > # prefer @b over @strong, so txt doesn't translate it to *Foo:* > - body += '\n\n@b{%s:}\n' % name > - > - body += func(doc) > + body += '\n\n@b{%s:}\n' % section.name > + text = str(section) > + if section.name.startswith('Example'): > + body += texi_example(text) > + else: > + body += texi_format(text) > return body > > > -- > 2.13.6 > >
diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py index a317526e51..f876d9a174 100755 --- a/scripts/qapi2texi.py +++ b/scripts/qapi2texi.py @@ -180,16 +180,14 @@ def texi_sections(doc): """Format additional sections following arguments""" body = '' for section in doc.sections: - name, doc = (section.name, str(section)) - func = texi_format - if name.startswith('Example'): - func = texi_example - - if name: + if section.name: # prefer @b over @strong, so txt doesn't translate it to *Foo:* - body += '\n\n@b{%s:}\n' % name - - body += func(doc) + body += '\n\n@b{%s:}\n' % section.name + text = str(section) + if section.name.startswith('Example'): + body += texi_example(text) + else: + body += texi_format(text) return body
Repurposing the function parameter doc for stepping through doc.sections.__str__() is not nice. Use new variable @text instead. While there, eliminate variables name and func. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- scripts/qapi2texi.py | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)