| Message ID | 20171002111111.26932-1-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171002111111.26932-1-armbru@redhat.com
Subject: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0915be50ad watchdog: Allow setting action on the fly
44e77bbf9d watchdog.h: Drop local redefinition of actions enum
8fcd8a0f85 qapi: Rename WatchdogExpirationAction enum
=== OUTPUT BEGIN ===
Checking PATCH 1/3: qapi: Rename WatchdogExpirationAction enum...
Checking PATCH 2/3: watchdog.h: Drop local redefinition of actions enum...
ERROR: braces {} are necessary for all arms of this statement
#57: FILE: hw/watchdog/watchdog.c:86:
+ if (action < 0)
[...]
total: 1 errors, 0 warnings, 130 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: watchdog: Allow setting action on the fly...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 10/02/2017 06:42 AM, no-reply@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Checking PATCH 2/3: watchdog.h: Drop local redefinition of actions enum... > ERROR: braces {} are necessary for all arms of this statement > #57: FILE: hw/watchdog/watchdog.c:86: > + if (action < 0) > [...] Pre-existing problem, but would indeed be easy to fix up as part of this series. I don't know if that means Markus should respin the pull request?
Eric Blake <eblake@redhat.com> writes: > On 10/02/2017 06:42 AM, no-reply@patchew.org wrote: >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> > >> Checking PATCH 2/3: watchdog.h: Drop local redefinition of actions enum... >> ERROR: braces {} are necessary for all arms of this statement >> #57: FILE: hw/watchdog/watchdog.c:86: >> + if (action < 0) >> [...] > > Pre-existing problem, but would indeed be easy to fix up as part of this > series. I don't know if that means Markus should respin the pull request? I would've touched it up in my tree had I seen it in time, but I doubt it's worth the bother now.
On 2 October 2017 at 12:11, Markus Armbruster <armbru@redhat.com> wrote: > The following changes since commit ab161529261928ae7f3556e3220829c34b2686ec: > > Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20170927a' into staging (2017-09-27 22:44:51 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-10-02 > > for you to fetch changes up to f0df84c6c46cb632dac2d9fae5fdbe6001527c3b: > > watchdog: Allow setting action on the fly (2017-10-02 13:09:09 +0200) > > ---------------------------------------------------------------- > QAPI patches for 2017-10-02 > > ---------------------------------------------------------------- > Michal Privoznik (3): > qapi: Rename WatchdogExpirationAction enum > watchdog.h: Drop local redefinition of actions enum > watchdog: Allow setting action on the fly > Applied, thanks. -- PMM
The following changes since commit ab161529261928ae7f3556e3220829c34b2686ec: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20170927a' into staging (2017-09-27 22:44:51 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-10-02 for you to fetch changes up to f0df84c6c46cb632dac2d9fae5fdbe6001527c3b: watchdog: Allow setting action on the fly (2017-10-02 13:09:09 +0200) ---------------------------------------------------------------- QAPI patches for 2017-10-02 ---------------------------------------------------------------- Michal Privoznik (3): qapi: Rename WatchdogExpirationAction enum watchdog.h: Drop local redefinition of actions enum watchdog: Allow setting action on the fly hw/watchdog/watchdog.c | 65 ++++++++++++++++++++++++----------------------- hw/watchdog/wdt_diag288.c | 6 ++--- include/sysemu/watchdog.h | 12 ++------- monitor.c | 4 +-- qapi-schema.json | 9 +++++++ qapi/run-state.json | 6 ++--- 6 files changed, 52 insertions(+), 50 deletions(-)