[ovs-dev,5/7] ofproto: Remove break after OVS_NOT_REACHED.

Message ID 1506844660-4902-5-git-send-email-bhanuprakash.bodireddy@intel.com
State Accepted
Headers show
Series
  • [ovs-dev,1/7] ccmap: Use PADDED_MEMBERS macro in ccmap_impl structure.
Related show

Commit Message

Bodireddy, Bhanuprakash Oct. 1, 2017, 7:57 a.m.
The break statement would never be executed as OVS_NOT_REACHED()
internally invokes abort() and causes process termination.

Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>
---
 ofproto/ofproto-dpif-ipfix.c | 1 -
 ofproto/ofproto-dpif-xlate.c | 2 --
 2 files changed, 3 deletions(-)

Patch

diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c
index 472c272..538faff 100644
--- a/ofproto/ofproto-dpif-ipfix.c
+++ b/ofproto/ofproto-dpif-ipfix.c
@@ -1314,7 +1314,6 @@  ipfix_def_options_template_fields(enum ipfix_options_template opt_tmpl_type,
     case NUM_IPFIX_OPTIONS_TEMPLATE:
     default:
         OVS_NOT_REACHED();
-        break;
     }
 
     return 0;
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index d320d57..0a71855 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -3229,7 +3229,6 @@  propagate_tunnel_data_to_flow(struct xlate_ctx *ctx, struct eth_addr dmac,
     case __OVS_VPORT_TYPE_MAX:
     default:
         OVS_NOT_REACHED();
-        break;
     }
     /*
      * Update base_flow first followed by flow as the dst_flow gets modified
@@ -5951,7 +5950,6 @@  xlate_generic_encap_action(struct xlate_ctx *ctx,
         default:
             /* New packet type was checked during decoding. */
             OVS_NOT_REACHED();
-            break;
     }
 
     if (!ctx->error) {