| Message ID | 20170929165906.18974-1-francois.perrad@gadz.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | lbase64: fix build | expand |
Hello, On Fri, 29 Sep 2017 18:59:06 +0200, Francois Perrad wrote: > see http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/ > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> Come on, "fix build" is really, really too short of a commit log. Please extend this commit log with a decent explanation. Thanks! Thomas
2017-09-29 21:52 GMT+02:00 Thomas Petazzoni < thomas.petazzoni@free-electrons.com>: > Hello, > > On Fri, 29 Sep 2017 18:59:06 +0200, Francois Perrad wrote: > > see http://autobuild.buildroot.net/results/b56/ > b567096cbfdb89b1895924051265c56204ffb512/ > > > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > > Come on, "fix build" is really, really too short of a commit log. > Please extend this commit log with a decent explanation. > > There are 3 useful words in http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/build-end.log : "recompile with -fPIC" François > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > <div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-09-29 21:52 GMT+02:00 Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@free-electrons.com" target="_blank">thomas.petazzoni@free-electrons.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br> <span class="gmail-"><br> On Fri, 29 Sep 2017 18:59:06 +0200, Francois Perrad wrote:<br> > see <a href="http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/" rel="noreferrer" target="_blank">http://autobuild.buildroot.<wbr>net/results/b56/<wbr>b567096cbfdb89b1895924051265c5<wbr>6204ffb512/</a><br> ><br> > Signed-off-by: Francois Perrad <<a href="mailto:francois.perrad@gadz.org">francois.perrad@gadz.org</a>><br> <br> </span>Come on, "fix build" is really, really too short of a commit log.<br> Please extend this commit log with a decent explanation.<br> <br></blockquote><div><br></div><div>There are 3 useful words in <br></div><div><a href="http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/build-end.log">http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/build-end.log</a> :<br></div><div> "recompile with -fPIC"</div><div><br></div><div>François <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Thanks!<br> <span class="gmail-HOEnZb"><font color="#888888"><br> Thomas<br> --<br> Thomas Petazzoni, CTO, Free Electrons<br> Embedded Linux and Kernel engineering<br> <a href="http://free-electrons.com" rel="noreferrer" target="_blank">http://free-electrons.com</a><br> ______________________________<wbr>_________________<br> buildroot mailing list<br> <a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br> <a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/<wbr>mailman/listinfo/buildroot</a><br> </font></span></blockquote></div><br></div></div>
Hello, On Sat, 30 Sep 2017 10:12:54 +0200, François Perrad wrote: > There are 3 useful words in > http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/build-end.log > : > "recompile with -fPIC" Still, please write better commit logs. Thanks, Thomas
On 29-09-17 18:59, Francois Perrad wrote: > see http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/ > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> I added a commit message and applied to master, thanks. However, wouldn't an upstreamable patch have been better? Regards, Arnout > --- > package/lbase64/lbase64.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/lbase64/lbase64.mk b/package/lbase64/lbase64.mk > index fd78a6ccd..0225fc67c 100644 > --- a/package/lbase64/lbase64.mk > +++ b/package/lbase64/lbase64.mk > @@ -12,7 +12,8 @@ LBASE64_LICENSE_FILES = README > LBASE64_DEPENDENCIES = luainterpreter > > define LBASE64_BUILD_CMDS > - $(MAKE1) $(TARGET_CONFIGURE_OPTS) -C $(@D) so > + $(MAKE1) $(TARGET_CONFIGURE_OPTS) \ > + CFLAGS="$(TARGET_CFLAGS) -fPIC" -C $(@D) so > endef > > define LBASE64_INSTALL_TARGET_CMDS >
diff --git a/package/lbase64/lbase64.mk b/package/lbase64/lbase64.mk index fd78a6ccd..0225fc67c 100644 --- a/package/lbase64/lbase64.mk +++ b/package/lbase64/lbase64.mk @@ -12,7 +12,8 @@ LBASE64_LICENSE_FILES = README LBASE64_DEPENDENCIES = luainterpreter define LBASE64_BUILD_CMDS - $(MAKE1) $(TARGET_CONFIGURE_OPTS) -C $(@D) so + $(MAKE1) $(TARGET_CONFIGURE_OPTS) \ + CFLAGS="$(TARGET_CFLAGS) -fPIC" -C $(@D) so endef define LBASE64_INSTALL_TARGET_CMDS
see http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/ Signed-off-by: Francois Perrad <francois.perrad@gadz.org> --- package/lbase64/lbase64.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)