diff mbox series

[U-Boot,010/080] core: Make device_is_compatible live-tree compatible

Message ID 20170929125238.26226-10-mario.six@gdsys.cc
State Accepted
Commit 29d11b8838bb2aa324b8873159cbd7088870a75b
Delegated to: Wolfgang Denk
Headers show
Series [U-Boot,001/080] mpc8308rdb: Fix style violation | expand

Commit Message

Mario Six Sept. 29, 2017, 12:51 p.m. UTC 
Judging from its name and parameters, device_is_compatible looks like it
is compatible with a live device tree, but it actually isn't.

Make is compatible with a live device tree.

Signed-off-by: Mario Six <mario.six@gdsys.cc>
---
 drivers/core/device.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Simon Glass Oct. 9, 2017, 4:46 a.m. UTC | #1 
On 29 September 2017 at 06:51, Mario Six <mario.six@gdsys.cc> wrote:
> Judging from its name and parameters, device_is_compatible looks like it
> is compatible with a live device tree, but it actually isn't.
>
> Make is compatible with a live device tree.
>
> Signed-off-by: Mario Six <mario.six@gdsys.cc>
> ---
>  drivers/core/device.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/drivers/core/device.c b/drivers/core/device.c
index 5463d1ffa5..23de6a6246 100644
--- a/drivers/core/device.c
+++ b/drivers/core/device.c
@@ -17,6 +17,7 @@ 
 #include <dm/device.h>
 #include <dm/device-internal.h>
 #include <dm/lists.h>
+#include <dm/of_access.h>
 #include <dm/pinctrl.h>
 #include <dm/platdata.h>
 #include <dm/read.h>
@@ -702,8 +703,12 @@  int device_set_name(struct udevice *dev, const char *name)
 bool device_is_compatible(struct udevice *dev, const char *compat)
 {
 	const void *fdt = gd->fdt_blob;
+	ofnode node = dev_ofnode(dev);
 
-	return !fdt_node_check_compatible(fdt, dev_of_offset(dev), compat);
+	if (ofnode_is_np(node))
+		return of_device_is_compatible(ofnode_to_np(node), compat, NULL, NULL);
+	else
+		return !fdt_node_check_compatible(fdt, ofnode_to_offset(node), compat);
 }
 
 bool of_machine_is_compatible(const char *compat)