[v2,2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c"

Message ID 20170928213605.22874-3-kalyan.kinthada@alliedtelesis.co.nz
State Needs Review / ACK
Headers show
Series
  • Fix I2C repeated start timing violation on Armada-38x.
Related show

Commit Message

Kalyan Kinthada Sept. 28, 2017, 9:36 p.m.
This commit modifies the documentation for
"marvell,mv78230-a0-i2c" compatible string.

The "marvell,mv78230-a0-i2c" compatible string enables the workaround
for an i2c repeated start timing violation, but unlike
"marvell,mv78230-i2c" it disables the i2c offload support. This is
applicable to a number of SoCs such as early revisions of the Armada XP
and the Armada 38x.

Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
---
 Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Gregory CLEMENT Oct. 2, 2017, 2:23 p.m. | #1
Hi Wolfram,
 
 On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:

> This commit modifies the documentation for
> "marvell,mv78230-a0-i2c" compatible string.
>
> The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> for an i2c repeated start timing violation, but unlike
> "marvell,mv78230-i2c" it disables the i2c offload support. This is
> applicable to a number of SoCs such as early revisions of the Armada XP
> and the Armada 38x.
>
> Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>


I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
one on your branch, or do you prefer I take it. In this case an acked-by
would be nice.

Thanks,

Gregory


> ---
>  Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> index 5c30026921ae..c6cbab17ed0a 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> @@ -10,10 +10,12 @@ Required properties :
>                       - "marvell,mv64xxx-i2c"
>                       - "marvell,mv78230-i2c"
>                       - "marvell,mv78230-a0-i2c"
> -                       * Note: Only use "marvell,mv78230-a0-i2c" for a
> -                         very rare, initial version of the SoC which
> -                         had broken offload support.  Linux
> -                         auto-detects this and sets it appropriately.
> +                       * Note: Use "marvell,mv78230-a0-i2c" for
> +                         controller which do not support offload
> +                         but still have the i2c repeated start
> +                         timing violation issue, such as the
> +                         ones found in the Armada XP A0 and the
> +                         Armada 38x SoCs.
>   - interrupts      : The interrupt number
>  
>  Optional properties :
> -- 
> 2.14.1
>
Wolfram Sang Oct. 5, 2017, 11:08 a.m. | #2
On Mon, Oct 02, 2017 at 04:23:43PM +0200, Gregory CLEMENT wrote:
> Hi Wolfram,
>  
>  On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:
> 
> > This commit modifies the documentation for
> > "marvell,mv78230-a0-i2c" compatible string.
> >
> > The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> > for an i2c repeated start timing violation, but unlike
> > "marvell,mv78230-i2c" it disables the i2c offload support. This is
> > applicable to a number of SoCs such as early revisions of the Armada XP
> > and the Armada 38x.
> >
> > Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
> 
> 
> I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
> one on your branch, or do you prefer I take it. In this case an acked-by
> would be nice.

I'd prefer to take it. What I'd really like to see here is an ack from
Rob because of the previous discussion of an earlier revision of this
patch.
Rob Herring Oct. 5, 2017, 11:29 p.m. | #3
On Thu, Oct 05, 2017 at 01:08:20PM +0200, Wolfram Sang wrote:
> On Mon, Oct 02, 2017 at 04:23:43PM +0200, Gregory CLEMENT wrote:
> > Hi Wolfram,
> >  
> >  On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:
> > 
> > > This commit modifies the documentation for
> > > "marvell,mv78230-a0-i2c" compatible string.
> > >
> > > The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> > > for an i2c repeated start timing violation, but unlike
> > > "marvell,mv78230-i2c" it disables the i2c offload support. This is
> > > applicable to a number of SoCs such as early revisions of the Armada XP
> > > and the Armada 38x.
> > >
> > > Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
> > 
> > 
> > I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
> > one on your branch, or do you prefer I take it. In this case an acked-by
> > would be nice.
> 
> I'd prefer to take it. What I'd really like to see here is an ack from
> Rob because of the previous discussion of an earlier revision of this
> patch.

I'm confused how mv78230 relates to Armada XP or 38x... I don't really 
want to know either. If normal compatible string conventions were 
followed then I wouldn't have to.

Rob
Wolfram Sang Nov. 5, 2017, 12:54 p.m. | #4
On Thu, Oct 05, 2017 at 06:29:53PM -0500, Rob Herring wrote:
> On Thu, Oct 05, 2017 at 01:08:20PM +0200, Wolfram Sang wrote:
> > On Mon, Oct 02, 2017 at 04:23:43PM +0200, Gregory CLEMENT wrote:
> > > Hi Wolfram,
> > >  
> > >  On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:
> > > 
> > > > This commit modifies the documentation for
> > > > "marvell,mv78230-a0-i2c" compatible string.
> > > >
> > > > The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> > > > for an i2c repeated start timing violation, but unlike
> > > > "marvell,mv78230-i2c" it disables the i2c offload support. This is
> > > > applicable to a number of SoCs such as early revisions of the Armada XP
> > > > and the Armada 38x.
> > > >
> > > > Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
> > > 
> > > 
> > > I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
> > > one on your branch, or do you prefer I take it. In this case an acked-by
> > > would be nice.
> > 
> > I'd prefer to take it. What I'd really like to see here is an ack from
> > Rob because of the previous discussion of an earlier revision of this
> > patch.
> 
> I'm confused how mv78230 relates to Armada XP or 38x... I don't really 
> want to know either. If normal compatible string conventions were 
> followed then I wouldn't have to.

Is this a NAK or "annoyed, but don't really care"? ;)

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
index 5c30026921ae..c6cbab17ed0a 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
@@ -10,10 +10,12 @@  Required properties :
                      - "marvell,mv64xxx-i2c"
                      - "marvell,mv78230-i2c"
                      - "marvell,mv78230-a0-i2c"
-                       * Note: Only use "marvell,mv78230-a0-i2c" for a
-                         very rare, initial version of the SoC which
-                         had broken offload support.  Linux
-                         auto-detects this and sets it appropriately.
+                       * Note: Use "marvell,mv78230-a0-i2c" for
+                         controller which do not support offload
+                         but still have the i2c repeated start
+                         timing violation issue, such as the
+                         ones found in the Armada XP A0 and the
+                         Armada 38x SoCs.
  - interrupts      : The interrupt number
 
 Optional properties :