| Message ID | 1506592361-26168-1-git-send-email-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | default-configs: Enable CONFIG_VMXNET3_PCI only on x86 | expand |
> On 28 Sep 2017, at 12:52 PM, Thomas Huth <thuth@redhat.com> wrote: > > The device can not be instantiated on many non-x86 and just prints > some error messages, e.g.: > > $ qemu-system-ppc64 -device vmxnet3 -M g3beige > [vmxnet3][WR][vmxnet3_init_msix]: Failed to initialize MSI-X, error -95 > [vmxnet3][WR][vmxnet3_pci_realize]: Failed to initialize MSI-X, configuration is inconsistent. > > Since vmxnet3 is a para-virtualized device that is only useful on x86, > it should also only be enabled on the x86 targets. > Reviewed-by: Dmitry Fleytman <dmitry@daynix.com> > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > default-configs/i386-softmmu.mak | 1 + > default-configs/pci.mak | 1 - > default-configs/x86_64-softmmu.mak | 1 + > 3 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak > index d2ab2f6..a685c43 100644 > --- a/default-configs/i386-softmmu.mak > +++ b/default-configs/i386-softmmu.mak > @@ -7,6 +7,7 @@ CONFIG_QXL=$(CONFIG_SPICE) > CONFIG_VGA_ISA=y > CONFIG_VGA_CIRRUS=y > CONFIG_VMWARE_VGA=y > +CONFIG_VMXNET3_PCI=y > CONFIG_VIRTIO_VGA=y > CONFIG_VMMOUSE=y > CONFIG_IPMI=y > diff --git a/default-configs/pci.mak b/default-configs/pci.mak > index 187e438..e514bde 100644 > --- a/default-configs/pci.mak > +++ b/default-configs/pci.mak > @@ -22,7 +22,6 @@ CONFIG_MPTSAS_SCSI_PCI=y > CONFIG_RTL8139_PCI=y > CONFIG_E1000_PCI=y > CONFIG_E1000E_PCI=y > -CONFIG_VMXNET3_PCI=y > CONFIG_IDE_CORE=y > CONFIG_IDE_QDEV=y > CONFIG_IDE_PCI=y > diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak > index 9bde2f1..ea69e82 100644 > --- a/default-configs/x86_64-softmmu.mak > +++ b/default-configs/x86_64-softmmu.mak > @@ -7,6 +7,7 @@ CONFIG_QXL=$(CONFIG_SPICE) > CONFIG_VGA_ISA=y > CONFIG_VGA_CIRRUS=y > CONFIG_VMWARE_VGA=y > +CONFIG_VMXNET3_PCI=y > CONFIG_VIRTIO_VGA=y > CONFIG_VMMOUSE=y > CONFIG_IPMI=y > -- > 1.8.3.1 >
diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak index d2ab2f6..a685c43 100644 --- a/default-configs/i386-softmmu.mak +++ b/default-configs/i386-softmmu.mak @@ -7,6 +7,7 @@ CONFIG_QXL=$(CONFIG_SPICE) CONFIG_VGA_ISA=y CONFIG_VGA_CIRRUS=y CONFIG_VMWARE_VGA=y +CONFIG_VMXNET3_PCI=y CONFIG_VIRTIO_VGA=y CONFIG_VMMOUSE=y CONFIG_IPMI=y diff --git a/default-configs/pci.mak b/default-configs/pci.mak index 187e438..e514bde 100644 --- a/default-configs/pci.mak +++ b/default-configs/pci.mak @@ -22,7 +22,6 @@ CONFIG_MPTSAS_SCSI_PCI=y CONFIG_RTL8139_PCI=y CONFIG_E1000_PCI=y CONFIG_E1000E_PCI=y -CONFIG_VMXNET3_PCI=y CONFIG_IDE_CORE=y CONFIG_IDE_QDEV=y CONFIG_IDE_PCI=y diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak index 9bde2f1..ea69e82 100644 --- a/default-configs/x86_64-softmmu.mak +++ b/default-configs/x86_64-softmmu.mak @@ -7,6 +7,7 @@ CONFIG_QXL=$(CONFIG_SPICE) CONFIG_VGA_ISA=y CONFIG_VGA_CIRRUS=y CONFIG_VMWARE_VGA=y +CONFIG_VMXNET3_PCI=y CONFIG_VIRTIO_VGA=y CONFIG_VMMOUSE=y CONFIG_IPMI=y
The device can not be instantiated on many non-x86 and just prints some error messages, e.g.: $ qemu-system-ppc64 -device vmxnet3 -M g3beige [vmxnet3][WR][vmxnet3_init_msix]: Failed to initialize MSI-X, error -95 [vmxnet3][WR][vmxnet3_pci_realize]: Failed to initialize MSI-X, configuration is inconsistent. Since vmxnet3 is a para-virtualized device that is only useful on x86, it should also only be enabled on the x86 targets. Signed-off-by: Thomas Huth <thuth@redhat.com> --- default-configs/i386-softmmu.mak | 1 + default-configs/pci.mak | 1 - default-configs/x86_64-softmmu.mak | 1 + 3 files changed, 2 insertions(+), 1 deletion(-)