diff mbox series

[net-next] net: ipv4: remove fib_info arg to fib_check_nh

Message ID 1506570119-17088-1-git-send-email-dsahern@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series [net-next] net: ipv4: remove fib_info arg to fib_check_nh | expand

Commit Message

David Ahern Sept. 28, 2017, 3:41 a.m. UTC
fib_check_nh does not use the fib_info arg; remove t.

Signed-off-by: David Ahern <dsahern@gmail.com>
---
 net/ipv4/fib_semantics.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

David Miller Sept. 29, 2017, 5:20 a.m. UTC | #1
From: David Ahern <dsahern@gmail.com>
Date: Wed, 27 Sep 2017 20:41:59 -0700

> fib_check_nh does not use the fib_info arg; remove t.
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>

Applied.
Sergei Shtylyov Oct. 1, 2017, 10:44 a.m. UTC | #2
Hello!

On 9/28/2017 6:41 AM, David Ahern wrote:

> fib_check_nh does not use the fib_info arg; remove t.

    s/t/it/. :-)

> Signed-off-by: David Ahern <dsahern@gmail.com>
[...]

MBR, Sergei
diff mbox series

Patch

diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 57a5d48acee8..79989124607e 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -774,8 +774,8 @@  bool fib_metrics_match(struct fib_config *cfg, struct fib_info *fi)
  *					|
  *					|-> {local prefix} (terminal node)
  */
-static int fib_check_nh(struct fib_config *cfg, struct fib_info *fi,
-			struct fib_nh *nh, struct netlink_ext_ack *extack)
+static int fib_check_nh(struct fib_config *cfg, struct fib_nh *nh,
+			struct netlink_ext_ack *extack)
 {
 	int err = 0;
 	struct net *net;
@@ -1258,7 +1258,7 @@  struct fib_info *fib_create_info(struct fib_config *cfg,
 		int linkdown = 0;
 
 		change_nexthops(fi) {
-			err = fib_check_nh(cfg, fi, nexthop_nh, extack);
+			err = fib_check_nh(cfg, nexthop_nh, extack);
 			if (err != 0)
 				goto failure;
 			if (nexthop_nh->nh_flags & RTNH_F_LINKDOWN)