From patchwork Wed Sep 27 20:41:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 819303 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YiBcNBa8"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3y2V9H0fwMz9t66 for ; Thu, 28 Sep 2017 06:41:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751892AbdI0Uli (ORCPT ); Wed, 27 Sep 2017 16:41:38 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33608 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbdI0Ulh (ORCPT ); Wed, 27 Sep 2017 16:41:37 -0400 Received: by mail-wm0-f67.google.com with SMTP id m127so12099261wmm.0 for ; Wed, 27 Sep 2017 13:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=ov59DOHYPq/nP3L9m7X6KglHC+UsqrdkyQjzLpwKCm0=; b=YiBcNBa8HoieCTEiPrW3tpY+wsZbQJ7s6CqAgl+7D06paqXG9q/nqMe7Y6Fm0ElN4O yOSMSE/rwZO8ijb9VxdRFYe9L+sKx+fOlICDAs0ZPO6fnRhEELCMk4+iqMbTG7tcOP0Y 12T16Uv2kkOFFDMUJBVGjneD+XjLFdwCAhVJJnVqn1/7NVzBOKnIjhZDz64mc+grDB0q 2nfkVF6kU7rbR4Vu+pM5KleHw3I7sxTC6Y0hHsN6svO5mtBWHvdHtGBkkfySR1diO2eZ 6MsRL/t4wxBaPWLbXknysfVDsi+c9SF+N2JbydbZozd0u/JucMoIQ+92b47/w2Wo6JQ9 /kIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=ov59DOHYPq/nP3L9m7X6KglHC+UsqrdkyQjzLpwKCm0=; b=JlPC9nvLhuaQsGVtrPbd2A9Dfi4UZSiOC9Qf/dQrd/8CgO1BnJgrqaDUw0ZvAAAr4g +W2307eIBH2XMkIZKiyRSydYS9Xnfec7zDTc17EeVOvLVv9ejB2QRS2Xcezu5jzQdxiu a4Ok92+jdLxJdprHy/nd07HEC3N1hd/z20GCJno0RzbaEpEqC3Uzir7lplyvxXKHWM3G metHIlgck3bhFFLaOy+LEYk5RPchI8K4L5FxEaUjXwR35REwcypPXwofohkLLnEvXAY0 1SFyPi8tz5K27vNUNn6YBoMhtLIKYOX+QrghoYD9JLb3aoFzcli9v9aTwP/TqZYpBQFN cUoQ== X-Gm-Message-State: AHPjjUg1UNXrDD++4uWx/yvjw/32KGvRvDN1oEbbKvydeKa8xqsJILZD 0N7qtwBFnXxmj7IooZwaJlelwg== X-Google-Smtp-Source: AOwi7QAkq8nP0nubJsqfc7jnydibGil38upiW58vKpAVRL/uJBBXZEmA8Hx7jfwbmTP2EPjeZW48tg== X-Received: by 10.80.192.71 with SMTP id u7mr3309428edd.153.1506544896158; Wed, 27 Sep 2017 13:41:36 -0700 (PDT) Received: from ?IPv6:2003:ea:8bc7:8200:5993:690a:5f60:9616? (p200300EA8BC782005993690A5F609616.dip0.t-ipconnect.de. [2003:ea:8bc7:8200:5993:690a:5f60:9616]) by smtp.googlemail.com with ESMTPSA id l33sm79209edd.94.2017.09.27.13.41.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Sep 2017 13:41:35 -0700 (PDT) To: Alexandre Belloni , linux-rtc@vger.kernel.org From: Heiner Kallweit Subject: [PATCH] rtc: ds1307: simplify hwmon config Message-ID: <1f2c13e2-8e44-1ff9-0647-24be3eb510d2@gmail.com> Date: Wed, 27 Sep 2017 22:41:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org We don't have to define an extra config symbol, IS_REACHABLE does what we need. And having this config symbol just to save the few bytes of hwmon support on non-DS3231 chips isn't worth it IMO (especially as the symbol is set per default). Signed-off-by: Heiner Kallweit --- drivers/rtc/Kconfig | 9 --------- drivers/rtc/rtc-ds1307.c | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index e0e58f3b..5572819d 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -244,15 +244,6 @@ config RTC_DRV_DS1307 This driver can also be built as a module. If so, the module will be called rtc-ds1307. -config RTC_DRV_DS1307_HWMON - bool "HWMON support for rtc-ds1307" - depends on RTC_DRV_DS1307 && HWMON - depends on !(RTC_DRV_DS1307=y && HWMON=m) - default y - help - Say Y here if you want to expose temperature sensor data on - rtc-ds1307 (only DS3231) - config RTC_DRV_DS1307_CENTURY bool "Century bit support for rtc-ds1307" depends on RTC_DRV_DS1307 diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index e7d9215c..699ac68a 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1005,7 +1005,7 @@ static u8 ds1307_trickle_init(struct ds1307 *ds1307, /*----------------------------------------------------------------------*/ -#ifdef CONFIG_RTC_DRV_DS1307_HWMON +#if IS_REACHABLE(CONFIG_HWMON) /* * Temperature sensor support for ds3231 devices.