Patchwork [U-Boot,14/32] sc520: Remove printf calls from cpu_init_f

login
register
mail settings
Submitter Graeme Russ
Date Feb. 4, 2011, 12:35 p.m.
Message ID <1296822959-3927-15-git-send-email-graeme.russ@gmail.com>
Download mbox | patch
Permalink /patch/81867/
State Accepted
Delegated to: Graeme Russ
Headers show

Comments

Graeme Russ - Feb. 4, 2011, 12:35 p.m.
In later patches, cpu_init_f will be called before console has been
initialised and printf will not be legitimately available

Signed-off-by: Graeme Russ <graeme.russ@gmail.com>
---
 arch/i386/cpu/sc520/sc520.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Graeme Russ - Feb. 12, 2011, 4:28 a.m.
On 04/02/11 23:35, Graeme Russ wrote:
> In later patches, cpu_init_f will be called before console has been
> initialised and printf will not be legitimately available
> 
> Signed-off-by: Graeme Russ <graeme.russ@gmail.com>
> ---
>  arch/i386/cpu/sc520/sc520.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 

Applied to u-boot-x86

Regards,

Graeme

Patch

diff --git a/arch/i386/cpu/sc520/sc520.c b/arch/i386/cpu/sc520/sc520.c
index 19a678d..76de6be 100644
--- a/arch/i386/cpu/sc520/sc520.c
+++ b/arch/i386/cpu/sc520/sc520.c
@@ -46,11 +46,9 @@  int cpu_init_f(void)
 		/* set it to 133 MHz and write back */
 		writeb(0x02, &sc520_mmcr->cpuctl);
 		gd->cpu_clk = 133000000;
-		printf("## CPU Speed set to 133MHz\n");
 	} else {
 		/* set it to 100 MHz and write back */
 		writeb(0x01, &sc520_mmcr->cpuctl);
-		printf("## CPU Speed set to 100MHz\n");
 		gd->cpu_clk = 100000000;
 	}