diff mbox series

docker: test-block: Don't continue if build fails

Message ID 20170926110134.2786-1-famz@redhat.com
State New
Headers show
Series docker: test-block: Don't continue if build fails | expand

Commit Message

Fam Zheng Sept. 26, 2017, 11:01 a.m. UTC
Report error and exit upon compiling error, otherwise the iotests output
will be pure noise.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/docker/test-block | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Blake Sept. 26, 2017, 1:48 p.m. UTC | #1
On 09/26/2017 06:01 AM, Fam Zheng wrote:
> Report error and exit upon compiling error, otherwise the iotests output
> will be pure noise.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/test-block | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/docker/test-block b/tests/docker/test-block
> index 2ca1ce54f6..5624b81827 100755
> --- a/tests/docker/test-block
> +++ b/tests/docker/test-block
> @@ -14,7 +14,7 @@
>  
>  cd "$BUILD_DIR"
>  
> -build_qemu --target-list=x86_64-softmmu
> +build_qemu --target-list=x86_64-softmmu || test_fail "Build failed"
>  cd tests/qemu-iotests
>  for t in raw qcow2 nbd luks; do
>      ./check -g quick -$t || test_fail "Test failed: iotests $t"
>
Fam Zheng Sept. 27, 2017, 5:47 a.m. UTC | #2
On Tue, 09/26 08:48, Eric Blake wrote:
> On 09/26/2017 06:01 AM, Fam Zheng wrote:
> > Report error and exit upon compiling error, otherwise the iotests output
> > will be pure noise.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  tests/docker/test-block | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Queued, thanks.

Fam
diff mbox series

Patch

diff --git a/tests/docker/test-block b/tests/docker/test-block
index 2ca1ce54f6..5624b81827 100755
--- a/tests/docker/test-block
+++ b/tests/docker/test-block
@@ -14,7 +14,7 @@ 
 
 cd "$BUILD_DIR"
 
-build_qemu --target-list=x86_64-softmmu
+build_qemu --target-list=x86_64-softmmu || test_fail "Build failed"
 cd tests/qemu-iotests
 for t in raw qcow2 nbd luks; do
     ./check -g quick -$t || test_fail "Test failed: iotests $t"