| Submitter | Vasiliy Kulikov |
|---|---|
| Date | Feb. 4, 2011, 12:24 p.m. |
| Message ID | <48f518983fa454135d7cfadef120edab35c94329.1296818921.git.segoon@openwall.com> |
| Download | mbox | patch |
| Permalink | /patch/81852/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncCJqjxdJ2EOvfr-oEGgTTkKMW@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-fx0-f56.google.com (mail-fx0-f56.google.com [209.85.161.56]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id B156EB713A for <incoming@patchwork.ozlabs.org>; Fri, 4 Feb 2011 23:24:16 +1100 (EST) Received: by fxm3 with SMTP id 3sf872365fxm.11 for <incoming@patchwork.ozlabs.org>; Fri, 04 Feb 2011 04:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:mime-version:x-beenthere:received-spf:sender :from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe:content-type; bh=OzCoqGnhotq52VcozaK3uBTmvrHMK8kGKjilgxGJ+oo=; b=1ZqPqy0sszmspMY/Vxu1/l9nxpOc76YrHb7DC44okSQVh59M76qTNO/9rFt6bbkAGA l/ZmlgmDUa3c4ef+AvXnWqyYaKsuceTBKbEGpLomTzqUFf8vDpYPugtwDoOheNdVeNNa szv8PahqZw50U93geyWARFqo5A6mC7YPekX0M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=mime-version:x-beenthere:received-spf:sender:from:to:cc:subject :date:message-id:x-mailer:in-reply-to:references:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:list-subscribe :list-unsubscribe:content-type; b=OA7yJFCexc/HE1N+QmTr23TQCIKm3NB4lWwat+IsQidR3LQluEyEHMj6KNrDmw40aa xdNdvhjqu8ZJ0y4uciRjASUBrJmRZJKxCM3GyBL+P9c3rUhTmhS0MfFonhIyohsInMLY rxord+0HBy7ojSDz/ZvM7Z0htx5DYYYRXb7TY= Received: by 10.223.161.195 with SMTP id s3mr1127876fax.26.1296822251959; Fri, 04 Feb 2011 04:24:11 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.204.179.8 with SMTP id bo8ls1469971bkb.1.p; Fri, 04 Feb 2011 04:24:11 -0800 (PST) Received: by 10.204.79.78 with SMTP id o14mr1183810bkk.13.1296822251190; Fri, 04 Feb 2011 04:24:11 -0800 (PST) Received: by 10.204.79.78 with SMTP id o14mr1183809bkk.13.1296822251168; Fri, 04 Feb 2011 04:24:11 -0800 (PST) Received: from mail-fx0-f51.google.com (mail-fx0-f51.google.com [209.85.161.51]) by gmr-mx.google.com with ESMTPS id n19si127451bks.5.2011.02.04.04.24.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 04 Feb 2011 04:24:10 -0800 (PST) Received-SPF: pass (google.com: domain of segooon@gmail.com designates 209.85.161.51 as permitted sender) client-ip=209.85.161.51; Received: by fxm5 with SMTP id 5so2392352fxm.10 for <rtc-linux@googlegroups.com>; Fri, 04 Feb 2011 04:24:09 -0800 (PST) Received: by 10.223.104.147 with SMTP id p19mr11453202fao.6.1296822249833; Fri, 04 Feb 2011 04:24:09 -0800 (PST) Received: from localhost (ppp85-141-141-135.pppoe.mtu-net.ru [85.141.141.135]) by mx.google.com with ESMTPS id 17sm201591far.19.2011.02.04.04.24.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 04 Feb 2011 04:24:09 -0800 (PST) Sender: rtc-linux@googlegroups.com From: Vasiliy Kulikov <segoon@openwall.com> To: linux-kernel@vger.kernel.org Cc: security@kernel.org, Alessandro Zummo <a.zummo@towertech.it> , rtc-linux@googlegroups.com Subject: [rtc-linux] [PATCH 17/20] rtc: rtc-ds1511: world-writable sysfs nvram file Date: Fri, 4 Feb 2011 15:24:06 +0300 Message-Id: <48f518983fa454135d7cfadef120edab35c94329.1296818921.git.segoon@openwall.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <cover.1296818921.git.segoon@openwall.com> References: <cover.1296818921.git.segoon@openwall.com> X-Original-Sender: segooon@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of segooon@gmail.com designates 209.85.161.51 as permitted sender) smtp.mail=segooon@gmail.com; dkim=pass (test mode) header.i=@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+unsubscribe@googlegroups.com> Content-Type: text/plain; charset=ISO-8859-1 |
Comments
Patch
diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c index 37268e9..afeb546 100644 --- a/drivers/rtc/rtc-ds1511.c +++ b/drivers/rtc/rtc-ds1511.c @@ -485,7 +485,7 @@ ds1511_nvram_write(struct file *filp, struct kobject *kobj, static struct bin_attribute ds1511_nvram_attr = { .attr = { .name = "nvram", - .mode = S_IRUGO | S_IWUGO, + .mode = S_IRUGO | S_IWUSR, }, .size = DS1511_RAM_MAX, .read = ds1511_nvram_read,
Don't allow everybogy to write to NVRAM. Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> --- Compile tested only. drivers/rtc/rtc-ds1511.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)