Patchwork [17/20] rtc: rtc-ds1511: world-writable sysfs nvram file

login
register
mail settings
Submitter Vasiliy Kulikov
Date Feb. 4, 2011, 12:24 p.m.
Message ID <48f518983fa454135d7cfadef120edab35c94329.1296818921.git.segoon@openwall.com>
Download mbox | patch
Permalink /patch/81852/
State New
Headers show

Comments

Vasiliy Kulikov - Feb. 4, 2011, 12:24 p.m.
Don't allow everybogy to write to NVRAM.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
 Compile tested only.

 drivers/rtc/rtc-ds1511.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c
index 37268e9..afeb546 100644
--- a/drivers/rtc/rtc-ds1511.c
+++ b/drivers/rtc/rtc-ds1511.c
@@ -485,7 +485,7 @@  ds1511_nvram_write(struct file *filp, struct kobject *kobj,
 static struct bin_attribute ds1511_nvram_attr = {
 	.attr = {
 		.name = "nvram",
-		.mode = S_IRUGO | S_IWUGO,
+		.mode = S_IRUGO | S_IWUSR,
 	},
 	.size = DS1511_RAM_MAX,
 	.read = ds1511_nvram_read,