Patchwork Change snapshot_blkdev hmp to use correct argument type for device

login
register
mail settings
Submitter Jes Sorensen
Date Feb. 4, 2011, 8:22 a.m.
Message ID <1296807734-19876-1-git-send-email-Jes.Sorensen@redhat.com>
Download mbox | patch
Permalink /patch/81826/
State New
Headers show

Comments

Jes Sorensen - Feb. 4, 2011, 8:22 a.m.
From: Jes Sorensen <Jes.Sorensen@redhat.com>

Pointed out by Markus

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 hmp-commands.hx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefan Hajnoczi - Feb. 4, 2011, 9:55 a.m.
On Fri, Feb 4, 2011 at 8:22 AM,  <Jes.Sorensen@redhat.com> wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> Pointed out by Markus
>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> ---
>  hmp-commands.hx |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Kevin Wolf - Feb. 7, 2011, 1:30 p.m.
Am 04.02.2011 09:22, schrieb Jes.Sorensen@redhat.com:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> Pointed out by Markus
> 
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>

Thanks, applied to the block branch.

Kevin

Patch

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 38e1eb7..372bef4 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -822,7 +822,7 @@  ETEXI
 
     {
         .name       = "snapshot_blkdev",
-        .args_type  = "device:s,snapshot_file:s?,format:s?",
+        .args_type  = "device:B,snapshot_file:s?,format:s?",
         .params     = "device [new-image-file] [format]",
         .help       = "initiates a live snapshot\n\t\t\t"
                       "of device. If a new image file is specified, the\n\t\t\t"