From patchwork Fri Feb 4 06:18:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 81810 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BB489B7109 for ; Fri, 4 Feb 2011 17:34:21 +1100 (EST) Received: from localhost ([127.0.0.1]:36371 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PlFFA-0006gl-3E for incoming@patchwork.ozlabs.org; Fri, 04 Feb 2011 01:34:08 -0500 Received: from [140.186.70.92] (port=54393 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PlF1j-0001EC-GL for qemu-devel@nongnu.org; Fri, 04 Feb 2011 01:20:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PlF1f-0003Np-SP for qemu-devel@nongnu.org; Fri, 04 Feb 2011 01:20:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PlF1f-0003NY-Dc for qemu-devel@nongnu.org; Fri, 04 Feb 2011 01:20:11 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p146KAhF016668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Feb 2011 01:20:10 -0500 Received: from localhost (ovpn-113-43.phx2.redhat.com [10.3.113.43]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p146K6fV020075; Fri, 4 Feb 2011 01:20:08 -0500 From: Amit Shah To: Anthony Liguori Date: Fri, 4 Feb 2011 11:48:49 +0530 Message-Id: <06982c027a250c1f5c2df8286f12d9b2aca8103a.1296800130.git.amit.shah@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Amit Shah , Kevin Wolf , qemu list , Markus Armbruster Subject: [Qemu-devel] [PATCH REBASE/RESEND 4/4] block_int.h: Provide documentation for common block qdev properties X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Document the options common to all block devices. This comes from Kevin. Signed-off-by: Amit Shah Acked-by: Markus Armbruster CC: Kevin Wolf --- block_int.h | 20 ++++++++++++-------- 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/block_int.h b/block_int.h index fdde005..2e72d1c 100644 --- a/block_int.h +++ b/block_int.h @@ -250,15 +250,19 @@ static inline unsigned int get_physical_block_exp(BlockConf *conf) } #define DEFINE_BLOCK_PROPERTIES(_state, _conf) \ - DEFINE_PROP_DRIVE("drive", _state, _conf.bs, ""), \ - DEFINE_PROP_UINT16("logical_block_size", _state, \ - _conf.logical_block_size, 512, ""), \ + DEFINE_PROP_DRIVE("drive", _state, _conf.bs, "The host drive details, specified by the -drive parameter"), \ + DEFINE_PROP_UINT16("logical_block_size", _state, _conf.logical_block_size, \ + 512, "Logical sector size of the disk"), \ DEFINE_PROP_UINT16("physical_block_size", _state, \ - _conf.physical_block_size, 512, ""), \ - DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0, ""), \ - DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0, ""), \ - DEFINE_PROP_INT32("bootindex", _state, _conf.bootindex, -1, ""), \ + _conf.physical_block_size, 512, "Physical sector size of the disk"), \ + DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0, \ + "Minimal size for IO requests in bytes. Must be a power of two that is 512 or greater."), \ + DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0, \ + "Size for IO requests that provides optimal performance (in bytes). Must be a power of two that is 512 or greater."), \ + DEFINE_PROP_INT32("bootindex", _state, _conf.bootindex, -1, \ + "The index this device will be tried to boot from"), \ DEFINE_PROP_UINT32("discard_granularity", _state, \ - _conf.discard_granularity, 0, "") + _conf.discard_granularity, 0, \ + "Number of free sectors needed to discard free blocks in a mapping image") #endif /* BLOCK_INT_H */