| Message ID | 20170922100823.18184-2-maxime.ripard@free-electrons.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | media: v4l: Add support for the Cadence MIPI-CSI2 RX | expand |
Hi Maxime, On Fri, Sep 22, 2017 at 12:08:22PM +0200, Maxime Ripard wrote: > The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to > 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on > the hardware implementation. > > It can operate with an external D-PHY, an internal one or no D-PHY at all > in some configurations. > > Acked-by: Rob Herring <robh@kernel.org> > Acked-by: Benoit Parrot <bparrot@ti.com> > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > .../devicetree/bindings/media/cdns,csi2rx.txt | 97 ++++++++++++++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.txt > > diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt > new file mode 100644 > index 000000000000..e9c30f964a96 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt > @@ -0,0 +1,97 @@ > +Cadence MIPI-CSI2 RX controller > +=============================== > + > +The Cadence MIPI-CSI2 RX controller is a CSI-2 bridge supporting up to 4 CSI > +lanes in input, and 4 different pixel streams in output. > + > +Required properties: > + - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible > + - reg: base address and size of the memory mapped region > + - clocks: phandles to the clocks driving the controller > + - clock-names: must contain: > + * sys_clk: main clock > + * p_clk: register bank clock > + * pixel_if[0-3]_clk: pixel stream output clock, one for each stream > + implemented in hardware, between 0 and 3 > + > +Optional properties: > + - phys: phandle to the external D-PHY, phy-names must be provided > + - phy-names: must contain dphy, if the implementation uses an > + external D-PHY > + > +Required subnodes: > + - ports: A ports node with one port child node per device input and output > + port, in accordance with the video interface bindings defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. The > + port nodes numbered as follows. > + > + Port Description > + ----------------------------- > + 0 CSI-2 input > + 1 Stream 0 output > + 2 Stream 1 output > + 3 Stream 2 output > + 4 Stream 3 output > + > + The stream output port nodes are optional if they are not connected > + to anything at the hardware level or implemented in the design. Could you add supported endpoint numbers, please? <URL:https://patchwork.linuxtv.org/patch/44409/> > + > +Example: > + > +csi2rx: csi-bridge@0d060000 { > + compatible = "cdns,csi2rx"; > + reg = <0x0d060000 0x1000>; > + clocks = <&byteclock>, <&byteclock> > + <&coreclock>, <&coreclock>, > + <&coreclock>, <&coreclock>; > + clock-names = "sys_clk", "p_clk", > + "pixel_if0_clk", "pixel_if1_clk", > + "pixel_if2_clk", "pixel_if3_clk"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + csi2rx_in_sensor: endpoint { > + remote-endpoint = <&sensor_out_csi2rx>; > + clock-lanes = <0>; > + data-lanes = <1 2>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + csi2rx_out_grabber0: endpoint { > + remote-endpoint = <&grabber0_in_csi2rx>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + > + csi2rx_out_grabber1: endpoint { > + remote-endpoint = <&grabber1_in_csi2rx>; > + }; > + }; > + > + port@3 { > + reg = <3>; > + > + csi2rx_out_grabber2: endpoint { > + remote-endpoint = <&grabber2_in_csi2rx>; > + }; > + }; > + > + port@4 { > + reg = <4>; > + > + csi2rx_out_grabber3: endpoint { > + remote-endpoint = <&grabber3_in_csi2rx>; > + }; > + }; > + }; > +}; > -- > 2.13.5 >
Hi Sakari, On Fri, Sep 22, 2017 at 11:35:23AM +0000, Sakari Ailus wrote: > Hi Maxime, > > On Fri, Sep 22, 2017 at 12:08:22PM +0200, Maxime Ripard wrote: > > The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to > > 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on > > the hardware implementation. > > > > It can operate with an external D-PHY, an internal one or no D-PHY at all > > in some configurations. > > > > Acked-by: Rob Herring <robh@kernel.org> > > Acked-by: Benoit Parrot <bparrot@ti.com> > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > --- > > .../devicetree/bindings/media/cdns,csi2rx.txt | 97 ++++++++++++++++++++++ > > 1 file changed, 97 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.txt > > > > diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt > > new file mode 100644 > > index 000000000000..e9c30f964a96 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt > > @@ -0,0 +1,97 @@ > > +Cadence MIPI-CSI2 RX controller > > +=============================== > > + > > +The Cadence MIPI-CSI2 RX controller is a CSI-2 bridge supporting up to 4 CSI > > +lanes in input, and 4 different pixel streams in output. > > + > > +Required properties: > > + - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible > > + - reg: base address and size of the memory mapped region > > + - clocks: phandles to the clocks driving the controller > > + - clock-names: must contain: > > + * sys_clk: main clock > > + * p_clk: register bank clock > > + * pixel_if[0-3]_clk: pixel stream output clock, one for each stream > > + implemented in hardware, between 0 and 3 > > + > > +Optional properties: > > + - phys: phandle to the external D-PHY, phy-names must be provided > > + - phy-names: must contain dphy, if the implementation uses an > > + external D-PHY > > + > > +Required subnodes: > > + - ports: A ports node with one port child node per device input and output > > + port, in accordance with the video interface bindings defined in > > + Documentation/devicetree/bindings/media/video-interfaces.txt. The > > + port nodes numbered as follows. > > + > > + Port Description > > + ----------------------------- > > + 0 CSI-2 input > > + 1 Stream 0 output > > + 2 Stream 1 output > > + 3 Stream 2 output > > + 4 Stream 3 output > > + > > + The stream output port nodes are optional if they are not connected > > + to anything at the hardware level or implemented in the design. > > Could you add supported endpoint numbers, please? > > <URL:https://patchwork.linuxtv.org/patch/44409/> So in the case where you have a single endpoint, usually you don't provide an endpoint number at all. Should I document it as zero, or as "no number"? Thanks! Maxime
Hi Maxime, On Fri, Sep 22, 2017 at 04:54:04PM +0200, Maxime Ripard wrote: > Hi Sakari, > > On Fri, Sep 22, 2017 at 11:35:23AM +0000, Sakari Ailus wrote: ... > > > + Documentation/devicetree/bindings/media/video-interfaces.txt. The > > > + port nodes numbered as follows. > > > + > > > + Port Description > > > + ----------------------------- > > > + 0 CSI-2 input > > > + 1 Stream 0 output > > > + 2 Stream 1 output > > > + 3 Stream 2 output > > > + 4 Stream 3 output > > > + > > > + The stream output port nodes are optional if they are not connected > > > + to anything at the hardware level or implemented in the design. > > > > Could you add supported endpoint numbers, please? > > > > <URL:https://patchwork.linuxtv.org/patch/44409/> > > So in the case where you have a single endpoint, usually you don't > provide an endpoint number at all. Should I document it as zero, or as > "no number"? Good question. If the endpoint numbers generally aren't meaningful for the device, no number should be equally good. But that should be documented. Just my opinion. I wonder what Rob thinks. I'll update the documentation patch.
diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt new file mode 100644 index 000000000000..e9c30f964a96 --- /dev/null +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt @@ -0,0 +1,97 @@ +Cadence MIPI-CSI2 RX controller +=============================== + +The Cadence MIPI-CSI2 RX controller is a CSI-2 bridge supporting up to 4 CSI +lanes in input, and 4 different pixel streams in output. + +Required properties: + - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible + - reg: base address and size of the memory mapped region + - clocks: phandles to the clocks driving the controller + - clock-names: must contain: + * sys_clk: main clock + * p_clk: register bank clock + * pixel_if[0-3]_clk: pixel stream output clock, one for each stream + implemented in hardware, between 0 and 3 + +Optional properties: + - phys: phandle to the external D-PHY, phy-names must be provided + - phy-names: must contain dphy, if the implementation uses an + external D-PHY + +Required subnodes: + - ports: A ports node with one port child node per device input and output + port, in accordance with the video interface bindings defined in + Documentation/devicetree/bindings/media/video-interfaces.txt. The + port nodes numbered as follows. + + Port Description + ----------------------------- + 0 CSI-2 input + 1 Stream 0 output + 2 Stream 1 output + 3 Stream 2 output + 4 Stream 3 output + + The stream output port nodes are optional if they are not connected + to anything at the hardware level or implemented in the design. + +Example: + +csi2rx: csi-bridge@0d060000 { + compatible = "cdns,csi2rx"; + reg = <0x0d060000 0x1000>; + clocks = <&byteclock>, <&byteclock> + <&coreclock>, <&coreclock>, + <&coreclock>, <&coreclock>; + clock-names = "sys_clk", "p_clk", + "pixel_if0_clk", "pixel_if1_clk", + "pixel_if2_clk", "pixel_if3_clk"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + csi2rx_in_sensor: endpoint { + remote-endpoint = <&sensor_out_csi2rx>; + clock-lanes = <0>; + data-lanes = <1 2>; + }; + }; + + port@1 { + reg = <1>; + + csi2rx_out_grabber0: endpoint { + remote-endpoint = <&grabber0_in_csi2rx>; + }; + }; + + port@2 { + reg = <2>; + + csi2rx_out_grabber1: endpoint { + remote-endpoint = <&grabber1_in_csi2rx>; + }; + }; + + port@3 { + reg = <3>; + + csi2rx_out_grabber2: endpoint { + remote-endpoint = <&grabber2_in_csi2rx>; + }; + }; + + port@4 { + reg = <4>; + + csi2rx_out_grabber3: endpoint { + remote-endpoint = <&grabber3_in_csi2rx>; + }; + }; + }; +};