| Message ID | 339edb91-644e-2456-b627-262d81c1afaa@grandegger.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2] package/dfu-util: allow to build it for the target as well | expand |
On 22-09-17 09:11, Wolfgang Grandegger wrote: > +config BR2_PACKAGE_DFU_UTIL > + bool "dfu-util" > + select BR2_PACKAGE_LIBUSB As I mentioned in my first reply, you also need to propagate libusb's dependency on threads and the corresponding comment. Regards, Arnout > + help > + Dfu-util is the host side implementation of the DFU 1.0 > + specification of the USB forum. DFU is intended to download > + and upload firmware to devices connected over USB. > + > + http://dfu-util.sourceforge.net/
Hello, Am 22.09.2017 um 13:32 schrieb Arnout Vandecappelle: > > > On 22-09-17 09:11, Wolfgang Grandegger wrote: >> +config BR2_PACKAGE_DFU_UTIL >> + bool "dfu-util" >> + select BR2_PACKAGE_LIBUSB > > As I mentioned in my first reply, you also need to propagate libusb's > dependency on threads and the corresponding comment. Then I have obviously not understood your comment. Looking into "package/libusb/Config.in": depends on BR2_TOOLCHAIN_HAS_THREADS comment "libusb needs a toolchain w/ threads" depends on !BR2_TOOLCHAIN_HAS_THREADS I will add similar lines in "dfu-util". Wolfgang.
diff --git a/package/Config.in b/package/Config.in index 48d1381..b493201 100644 --- a/package/Config.in +++ b/package/Config.in @@ -389,6 +389,7 @@ endmenu source "package/dbus-python/Config.in" source "package/dbus-triggerd/Config.in" source "package/devmem2/Config.in" + source "package/dfu-util/Config.in" source "package/dmidecode/Config.in" source "package/dmraid/Config.in" source "package/dt-utils/Config.in" diff --git a/package/dfu-util/Config.in b/package/dfu-util/Config.in new file mode 100644 index 0000000..ef1fd59 --- /dev/null +++ b/package/dfu-util/Config.in @@ -0,0 +1,9 @@ +config BR2_PACKAGE_DFU_UTIL + bool "dfu-util" + select BR2_PACKAGE_LIBUSB + help + Dfu-util is the host side implementation of the DFU 1.0 + specification of the USB forum. DFU is intended to download + and upload firmware to devices connected over USB. + + http://dfu-util.sourceforge.net/ diff --git a/package/dfu-util/dfu-util.mk b/package/dfu-util/dfu-util.mk index c494485..5e8ba5a 100644 --- a/package/dfu-util/dfu-util.mk +++ b/package/dfu-util/dfu-util.mk @@ -9,6 +9,8 @@ DFU_UTIL_SITE = http://dfu-util.sourceforge.net/releases DFU_UTIL_LICENSE = GPL-2.0+ DFU_UTIL_LICENSE_FILES = COPYING +DFU_UTIL_DEPENDENCIES = libusb HOST_DFU_UTIL_DEPENDENCIES = host-libusb +$(eval $(autotools-package)) $(eval $(host-autotools-package))
Signed-off-by: Wolfgang Grandegger <wg@grandegger.com> --- Changes since v1: - add missing "select BR2_PACKAGE_LIBUSB" in Config.in package/Config.in | 1 + package/dfu-util/Config.in | 9 +++++++++ package/dfu-util/dfu-util.mk | 2 ++ 3 files changed, 12 insertions(+) create mode 100644 package/dfu-util/Config.in