MAINTAINERS: Fix subsystem name for "Build and test automation"
diff mbox series

Message ID 20170921170209.9101-1-ehabkost@redhat.com
State New
Headers show
Series
  • MAINTAINERS: Fix subsystem name for "Build and test automation"
Related show

Commit Message

Eduardo Habkost Sept. 21, 2017, 5:02 p.m. UTC
The subsystem name for the "Build test automation" section is
"-------------------------", because an actual subsystem name
line is missing:

  $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
  "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
  Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
  "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
  qemu-devel@nongnu.org (open list:-----------------...)

Fix the issue by inserting a subsystem name line where
get_maintainer.pl expects it.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Fam Zheng Sept. 22, 2017, 2:21 a.m. UTC | #1
On Thu, 09/21 14:02, Eduardo Habkost wrote:
> The subsystem name for the "Build test automation" section is
> "-------------------------", because an actual subsystem name
> line is missing:
> 
>   $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
>   "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
>   Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
>   "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
>   qemu-devel@nongnu.org (open list:-----------------...)
> 
> Fix the issue by inserting a subsystem name line where
> get_maintainer.pl expects it.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e511ba780f..13c1ac65b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
>  
>  Build and test automation
>  -------------------------
> +Build and test automation
>  M: Alex Bennée <alex.bennee@linaro.org>
>  M: Fam Zheng <famz@redhat.com>
>  R: Philippe Mathieu-Daudé <f4bug@amsat.org>
> -- 
> 2.13.5
> 

Queued, thanks.

Fam
Thomas Huth Sept. 22, 2017, 3:14 a.m. UTC | #2
On 21.09.2017 19:02, Eduardo Habkost wrote:
> The subsystem name for the "Build test automation" section is
> "-------------------------", because an actual subsystem name
> line is missing:
> 
>   $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
>   "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
>   Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
>   "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
>   qemu-devel@nongnu.org (open list:-----------------...)
> 
> Fix the issue by inserting a subsystem name line where
> get_maintainer.pl expects it.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e511ba780f..13c1ac65b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
>  
>  Build and test automation
>  -------------------------
> +Build and test automation

Would it make sense to use something more specific here? Like "Travis
and Docker" or so? ... in case we add other subsections in the future?

 Thomas
Fam Zheng Sept. 22, 2017, 3:30 a.m. UTC | #3
On Fri, 09/22 05:14, Thomas Huth wrote:
> On 21.09.2017 19:02, Eduardo Habkost wrote:
> > The subsystem name for the "Build test automation" section is
> > "-------------------------", because an actual subsystem name
> > line is missing:
> > 
> >   $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
> >   "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
> >   Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
> >   "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
> >   qemu-devel@nongnu.org (open list:-----------------...)
> > 
> > Fix the issue by inserting a subsystem name line where
> > get_maintainer.pl expects it.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e511ba780f..13c1ac65b7 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
> >  
> >  Build and test automation
> >  -------------------------
> > +Build and test automation
> 
> Would it make sense to use something more specific here? Like "Travis
> and Docker" or so? ... in case we add other subsections in the future?

Unless we are to split off (i.e. more people volunteering maintaining a certain
subset), the list will just go on and on in this line. For not it's already
going to be "Travis, Shippable, Docker and VM test".. so I think a generic
description here is okay, though the duplication is a bit odd (but I don't have
a better idea).

Fam
Eric Blake Sept. 22, 2017, 9:02 p.m. UTC | #4
On 09/21/2017 10:30 PM, Fam Zheng wrote:

>>>  Build and test automation
>>>  -------------------------
>>> +Build and test automation
>>
>> Would it make sense to use something more specific here? Like "Travis
>> and Docker" or so? ... in case we add other subsections in the future?
> 
> Unless we are to split off (i.e. more people volunteering maintaining a certain
> subset), the list will just go on and on in this line. For not it's already
> going to be "Travis, Shippable, Docker and VM test".. so I think a generic
> description here is okay, though the duplication is a bit odd (but I don't have
> a better idea).

Or we could make a generic section of "Build, Tests, and Documentation",
and merge in the "Build system architecture" of the
immediately-subsequent "Documentation" section, as well as possibly any
future sections for someone to maintain top-level build-related files
(including MAINTAINERS itself...), so that we have just one larger
section with multiple sub-sections, instead of two sections each with
one sub-section.
Fam Zheng Sept. 25, 2017, 2:37 a.m. UTC | #5
On Fri, 09/22 16:02, Eric Blake wrote:
> On 09/21/2017 10:30 PM, Fam Zheng wrote:
> 
> >>>  Build and test automation
> >>>  -------------------------
> >>> +Build and test automation
> >>
> >> Would it make sense to use something more specific here? Like "Travis
> >> and Docker" or so? ... in case we add other subsections in the future?
> > 
> > Unless we are to split off (i.e. more people volunteering maintaining a certain
> > subset), the list will just go on and on in this line. For not it's already
> > going to be "Travis, Shippable, Docker and VM test".. so I think a generic
> > description here is okay, though the duplication is a bit odd (but I don't have
> > a better idea).
> 
> Or we could make a generic section of "Build, Tests, and Documentation",
> and merge in the "Build system architecture" of the
> immediately-subsequent "Documentation" section, as well as possibly any
> future sections for someone to maintain top-level build-related files
> (including MAINTAINERS itself...), so that we have just one larger
> section with multiple sub-sections, instead of two sections each with
> one sub-section.

That sounds okay, but actually most of the files under docs/ don't have a
maintainer, so in the hope that one day they will, the "Documentation" section
may be a good place to host more entries.

Fam

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index e511ba780f..13c1ac65b7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1896,6 +1896,7 @@  F: docs/block-replication.txt
 
 Build and test automation
 -------------------------
+Build and test automation
 M: Alex Bennée <alex.bennee@linaro.org>
 M: Fam Zheng <famz@redhat.com>
 R: Philippe Mathieu-Daudé <f4bug@amsat.org>