mbox

[PULL,0/7] target-mips queue

Message ID 1506001091-8296-1-git-send-email-yongbok.kim@imgtec.com
State New
Headers show

Pull-request

git://github.com/yongbok/upstream-qemu.git tags/mips-20170921

Message

Yongbok Kim Sept. 21, 2017, 1:38 p.m. UTC 
Hi, 

The patch 1 and 2 contain checkpatch.pl errors but patch 1 is relocating a file
and patch 2 has false positive warnings.

Regards,
Yongbok

The following changes since commit ff5667ed53c544c4dc88dcd7cb23cc509c9a55e0:

  Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into staging (2017-09-21 10:56:09 +0100)

are available in the git repository at:

  git://github.com/yongbok/upstream-qemu.git tags/mips-20170921

for you to fetch changes up to 2a2be359c4335607c7f746cf27c412c08ab89aff:

  mips: Improve macro parenthesization (2017-09-21 13:25:41 +0100)

----------------------------------------------------------------
MIPS patches 2017-09-21

Changes:
QOMify MIPS cpu
Improve macro parenthesization

----------------------------------------------------------------

Eric Blake (1):
  mips: Improve macro parenthesization

Igor Mammedov (2):
  mips: MIPSCPU model subclasses
  mips: replace cpu_mips_init() with cpu_generic_init()

Philippe Mathieu-Daudé (4):
  mips: move hw/mips/cputimer.c to target/mips/
  mips: introduce internal.h and cleanup cpu.h
  mips: split cpu_mips_realize_env() out of cpu_mips_init()
  mips: call cpu_mips_realize_env() from mips_cpu_realizefn()

 hw/mips/Makefile.objs        |   2 +-
 hw/mips/cps.c                |   2 +-
 hw/mips/cputimer.c           | 165 -----------------
 hw/mips/mips_fulong2e.c      |   2 +-
 hw/mips/mips_jazz.c          |   2 +-
 hw/mips/mips_malta.c         |   2 +-
 hw/mips/mips_mipssim.c       |   2 +-
 hw/mips/mips_r4k.c           |   2 +-
 target/mips/Makefile.objs    |   2 +-
 target/mips/cp0_timer.c      | 165 +++++++++++++++++
 target/mips/cpu-qom.h        |   1 +
 target/mips/cpu.c            |  54 +++++-
 target/mips/cpu.h            | 357 +-----------------------------------
 target/mips/dsp_helper.c     |  56 +++---
 target/mips/gdbstub.c        |   1 +
 target/mips/helper.c         |   1 +
 target/mips/internal.h       | 422 +++++++++++++++++++++++++++++++++++++++++++
 target/mips/kvm.c            |   1 +
 target/mips/machine.c        |   1 +
 target/mips/msa_helper.c     |   1 +
 target/mips/op_helper.c      |   1 +
 target/mips/translate.c      |  23 +--
 target/mips/translate_init.c |  58 +-----
 23 files changed, 692 insertions(+), 631 deletions(-)
 delete mode 100644 hw/mips/cputimer.c
 create mode 100644 target/mips/cp0_timer.c
 create mode 100644 target/mips/internal.h

Comments

no-reply@patchew.org Sept. 21, 2017, 1:55 p.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 0/7] target-mips queue
Message-id: 1506001091-8296-1-git-send-email-yongbok.kim@imgtec.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1506001091-8296-1-git-send-email-yongbok.kim@imgtec.com -> patchew/1506001091-8296-1-git-send-email-yongbok.kim@imgtec.com
Switched to a new branch 'test'
116019051c mips: Improve macro parenthesization
acd068893a mips: replace cpu_mips_init() with cpu_generic_init()
39800b8ba2 mips: MIPSCPU model subclasses
9b397529e6 mips: call cpu_mips_realize_env() from mips_cpu_realizefn()
91d8418edd mips: split cpu_mips_realize_env() out of cpu_mips_init()
925c58e3ac mips: introduce internal.h and cleanup cpu.h
3b898a7dc8 mips: move hw/mips/cputimer.c to target/mips/

=== OUTPUT BEGIN ===
Checking PATCH 1/7: mips: move hw/mips/cputimer.c to target/mips/...
Checking PATCH 2/7: mips: introduce internal.h and cleanup cpu.h...
ERROR: space prohibited after that '&' (ctx:WxW)
#729: FILE: target/mips/internal.h:230:
+    if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) {
                                              ^

ERROR: space prohibited after that '&' (ctx:WxW)
#737: FILE: target/mips/internal.h:238:
+            ((other_cpu->env.CP0_VPControl >> CP0VPCtl_DIS) & 1)) {
                                                             ^

ERROR: space prohibited after that '&' (ctx:WxW)
#757: FILE: target/mips/internal.h:258:
+        env->hflags |= (env->CP0_Status >> CP0St_KSU) & MIPS_HFLAG_KSU;
                                                       ^

total: 3 errors, 0 warnings, 842 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/7: mips: split cpu_mips_realize_env() out of cpu_mips_init()...
Checking PATCH 4/7: mips: call cpu_mips_realize_env() from mips_cpu_realizefn()...
Checking PATCH 5/7: mips: MIPSCPU model subclasses...
Checking PATCH 6/7: mips: replace cpu_mips_init() with cpu_generic_init()...
Checking PATCH 7/7: mips: Improve macro parenthesization...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Peter Maydell Sept. 21, 2017, 2:41 p.m. UTC | #2 
On 21 September 2017 at 14:38, Yongbok Kim <yongbok.kim@imgtec.com> wrote:
> Hi,
>
> The patch 1 and 2 contain checkpatch.pl errors but patch 1 is relocating a file
> and patch 2 has false positive warnings.
>
> Regards,
> Yongbok
>
> The following changes since commit ff5667ed53c544c4dc88dcd7cb23cc509c9a55e0:
>
>   Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into staging (2017-09-21 10:56:09 +0100)
>
> are available in the git repository at:
>
>   git://github.com/yongbok/upstream-qemu.git tags/mips-20170921
>
> for you to fetch changes up to 2a2be359c4335607c7f746cf27c412c08ab89aff:
>
>   mips: Improve macro parenthesization (2017-09-21 13:25:41 +0100)
>
> ----------------------------------------------------------------
> MIPS patches 2017-09-21
>
> Changes:
> QOMify MIPS cpu
> Improve macro parenthesization
>

Applied, thanks.

-- PMM