| Message ID | 1505908443-21798-1-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Accepted |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | [U-Boot] rockchip: imply ADC and SARADC_ROCKCHIP on supported SoCs | expand |
Hi Philipp, 在 2017/9/20 19:54, Philipp Tomsich 写道: > Enable the Rockchip SARADC driver on all supported SoCs (i.e. all > except the RK3036 and RK3228, which don't have this peripheral): > RK3188, RK3288, RK3328, RK3368, RK3399 and RV1108. > > Signed-off-by: Philipp Tomsich<philipp.tomsich@theobroma-systems.com> > --- Reviewed-by: David Wu <david.wu@rock-chips.com>
David, > On 20 Sep 2017, at 14:25, David.Wu <david.wu@rock-chips.com> wrote: > > Hi Philipp, > > 在 2017/9/20 19:54, Philipp Tomsich 写道: >> Enable the Rockchip SARADC driver on all supported SoCs (i.e. all >> except the RK3036 and RK3228, which don't have this peripheral): >> RK3188, RK3288, RK3328, RK3368, RK3399 and RV1108. >> Signed-off-by: Philipp Tomsich<philipp.tomsich@theobroma-systems.com> >> --- > > Reviewed-by: David Wu <david.wu@rock-chips.com> Should we just imply these two configuration-values for all Rockchip devices (i.e. even for the RK3036 and RK3228) to further simplify the Kconfig? What do you think? —Phil.
Hi Philipp, 在 2017/9/20 21:00, Dr. Philipp Tomsich 写道: > Should we just imply these two configuration-values for all Rockchip > devices (i.e. even for the RK3036 and RK3228) to further simplify the > Kconfig? I think it is okay to imply all rockchip devices, it is no harm. If after all Rockchip chips'defconfig is the same one, only one is rockchip_defconfig, we don't have this problem. now of defconfig indeed too much.
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index d9b25d5..399c889 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -21,6 +21,8 @@ config ROCKCHIP_RK3188 select TPL select BOARD_LATE_INIT select ROCKCHIP_BROM_HELPER + imply ADC + imply SARADC_ROCKCHIP help The Rockchip RK3188 is a ARM-based SoC with a quad-core Cortex-A9 including NEON and GPU, 512KB L2 cache, Mali-400 graphics, two @@ -47,6 +49,8 @@ config ROCKCHIP_RK3288 select SPL_BOARD_INIT if SPL select SUPPORT_SPL select SPL + imply ADC + imply SARADC_ROCKCHIP help The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17 including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two @@ -57,6 +61,8 @@ config ROCKCHIP_RK3288 config ROCKCHIP_RK3328 bool "Support Rockchip RK3328" select ARM64 + imply ADC + imply SARADC_ROCKCHIP help The Rockchip RK3328 is a ARM-based SoC with a quad-core Cortex-A53. including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two @@ -77,6 +83,8 @@ config ROCKCHIP_RK3368 select ENABLE_ARM_SOC_BOOT0_HOOK select DEBUG_UART_BOARD_INIT select SYS_NS16550 + imply ADC + imply SARADC_ROCKCHIP help The Rockchip RK3368 is a ARM-based SoC with a octa-core (organised into a big and little cluster with 4 cores each) Cortex-A53 including @@ -114,6 +122,8 @@ config ROCKCHIP_RK3399 select SPL_DRIVERS_MISC_SUPPORT select ENABLE_ARM_SOC_BOOT0_HOOK select DEBUG_UART_BOARD_INIT + imply ADC + imply SARADC_ROCKCHIP help The Rockchip RK3399 is a ARM-based SoC with a dual-core Cortex-A72 and quad-core Cortex-A53. @@ -125,6 +135,8 @@ config ROCKCHIP_RK3399 config ROCKCHIP_RV1108 bool "Support Rockchip RV1108" select CPU_V7 + imply ADC + imply SARADC_ROCKCHIP help The Rockchip RV1108 is a ARM-based SoC with a single-core Cortex-A7 and a DSP.
Enable the Rockchip SARADC driver on all supported SoCs (i.e. all except the RK3036 and RK3228, which don't have this peripheral): RK3188, RK3288, RK3328, RK3368, RK3399 and RV1108. Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- arch/arm/mach-rockchip/Kconfig | 12 ++++++++++++ 1 file changed, 12 insertions(+)