diff mbox series

[2/3] UBUNTU: SAUCE: opennsl: bcm-knet: remove redundant null checks on dev->name

Message ID 20170920102707.8266-3-colin.king@canonical.com
State New
Headers show
Series UBUNTU: SAUCE: opennsl: fix static analysis issues | expand

Commit Message

Colin Ian King Sept. 20, 2017, 10:27 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

BugLink: https://launchpad.net/bugs/1718388

dev->name is a char array and hence can never be null and so the
null checks on dev->name are redundant. Remove them.

Detected by CoverityScan CID#1456897, CID#145690 ("Array compared
against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 .../systems/linux/kernel/modules/bcm-knet/bcm-knet.c                  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Juerg Haefliger Sept. 21, 2017, 6:09 a.m. UTC | #1 
On 09/20/2017 12:27 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> BugLink: https://launchpad.net/bugs/1718388
> 
> dev->name is a char array and hence can never be null and so the
> null checks on dev->name are redundant. Remove them.
> 
> Detected by CoverityScan CID#1456897, CID#145690 ("Array compared
> against 0")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  .../systems/linux/kernel/modules/bcm-knet/bcm-knet.c                  | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
> index 9aed5dc..8f9589f 100644
> --- a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
> +++ b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
> @@ -3786,7 +3786,7 @@ bkn_proc_link_show(struct seq_file *m, void *v)
>          list_for_each(dlist, &sinfo->ndev_list) {
>              priv = (bkn_priv_t *)dlist;
>              dev = priv->dev;
> -            if (dev && dev->name) {
> +            if (dev) {
>                  seq_printf(m, "  %-14s %s\n", dev->name,
>                             netif_carrier_ok(dev) ? "up" : "down");
>              }
> @@ -3847,7 +3847,7 @@ bkn_proc_link_write(struct file *file, const char *buf,
>          list_for_each(dlist, &sinfo->ndev_list) {
>              priv = (bkn_priv_t *)dlist;
>              dev = priv->dev;
> -            if (dev && dev->name) {
> +            if (dev) {
>                  if (memcmp(dev->name, link_str, len) == 0) {
>                      break;
>                  }
> 

Acked-by: Juerg Haefliger <juerg.haefliger@canonical.com>
diff mbox series

Patch

diff --git a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
index 9aed5dc..8f9589f 100644
--- a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
+++ b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
@@ -3786,7 +3786,7 @@  bkn_proc_link_show(struct seq_file *m, void *v)
         list_for_each(dlist, &sinfo->ndev_list) {
             priv = (bkn_priv_t *)dlist;
             dev = priv->dev;
-            if (dev && dev->name) {
+            if (dev) {
                 seq_printf(m, "  %-14s %s\n", dev->name,
                            netif_carrier_ok(dev) ? "up" : "down");
             }
@@ -3847,7 +3847,7 @@  bkn_proc_link_write(struct file *file, const char *buf,
         list_for_each(dlist, &sinfo->ndev_list) {
             priv = (bkn_priv_t *)dlist;
             dev = priv->dev;
-            if (dev && dev->name) {
+            if (dev) {
                 if (memcmp(dev->name, link_str, len) == 0) {
                     break;
                 }