diff mbox series

PCI: Avoid non working configurations for PCI_REALLOC_ENABLE_AUTO

Message ID F6127EC53C695C46907CD6EE43F346235291129068@messagesink.samelson.uni-hildesheim.de
State Accepted
Headers show
Series PCI: Avoid non working configurations for PCI_REALLOC_ENABLE_AUTO | expand

Commit Message

Sascha El-Sharkawy Sept. 20, 2017, 6:44 a.m. UTC
Ensure only valid Kconfig configurations for PCI_REALLOC_ENABLE_AUTO. This
is done by selecting PCI_IOV, which is required by PCI_REALLOC_ENABLE_AUTO
to work.

Signed-off-by:  Sascha El-Sharkawy <elscha@sse.uni-hildesheim.de>

---
 drivers/pci/Kconfig |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Bjorn Helgaas Sept. 26, 2017, 9:30 p.m. UTC | #1
On Wed, Sep 20, 2017 at 08:44:20AM +0200, Sascha El-Sharkawy wrote:
> Ensure only valid Kconfig configurations for PCI_REALLOC_ENABLE_AUTO. This
> is done by selecting PCI_IOV, which is required by PCI_REALLOC_ENABLE_AUTO
> to work.
> 
> Signed-off-by:  Sascha El-Sharkawy <elscha@sse.uni-hildesheim.de>

Applied to pci/virtualization for v4.15, thanks!

I had to apply this manually because it wasn't plain ASCII and had CR
line endings.  But this was small enough to do by hand :)

> ---
>  drivers/pci/Kconfig |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig index c32a77fc8b03..675d79c52709 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -42,13 +42,13 @@ config PCI_DEBUG
>  config PCI_REALLOC_ENABLE_AUTO
>  	bool "Enable PCI resource re-allocation detection"
>  	depends on PCI
> +	depends on PCI_IOV
>  	help
>  	  Say Y here if you want the PCI core to detect if PCI resource
>  	  re-allocation needs to be enabled. You can always use pci=realloc=on
> -          or pci=realloc=off to override it.  Note this feature is a no-op
> -          unless PCI_IOV support is also enabled; in that case it will
> -          automatically re-allocate PCI resources if SR-IOV BARs have not
> -          been allocated by the BIOS.
> +	  or pci=realloc=off to override it.  It will automatically
> +	  re-allocate PCI resources if SR-IOV BARs have not been allocated by
> +	  the BIOS.
>  
>  	  When in doubt, say N.
>
diff mbox series

Patch

diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig index c32a77fc8b03..675d79c52709 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -42,13 +42,13 @@  config PCI_DEBUG
 config PCI_REALLOC_ENABLE_AUTO
 	bool "Enable PCI resource re-allocation detection"
 	depends on PCI
+	depends on PCI_IOV
 	help
 	  Say Y here if you want the PCI core to detect if PCI resource
 	  re-allocation needs to be enabled. You can always use pci=realloc=on
-          or pci=realloc=off to override it.  Note this feature is a no-op
-          unless PCI_IOV support is also enabled; in that case it will
-          automatically re-allocate PCI resources if SR-IOV BARs have not
-          been allocated by the BIOS.
+	  or pci=realloc=off to override it.  It will automatically
+	  re-allocate PCI resources if SR-IOV BARs have not been allocated by
+	  the BIOS.
 
 	  When in doubt, say N.