| Message ID | 20170920044618.25555-1-mikey@neuling.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | fsp: Move common prints to trace | expand |
Michael Neuling <mikey@neuling.org> writes: > These two prints just end up filling the skiboot logs on any machine > that's been booted for more than a few hours. > > They have never been useful, so make them trace level. > > Signed-off-by: Michael Neuling <mikey@neuling.org> Yeah, about time for this. I think if we want a good way of working out when the last heartbeats were sent/received we should just put something in the debug descriptor and be done with it (and ensure that's in MDST). Merged to master as of 9c1870022d131e18bbe2858ff90731e83a95c5d4
On Wed, Sep 20, 2017 at 04:46:18AM +0000, Michael Neuling wrote: > These two prints just end up filling the skiboot logs on any machine > that's been booted for more than a few hours. > > They have never been useful, so make them trace level. They were useful in the past to detect if OPAL itself was functional, etc., but that was during the early development. Ben had indeed vetoed such a patch in the past IIRC, but this may be fine now. > Signed-off-by: Michael Neuling <mikey@neuling.org> Acked-by: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
diff --git a/hw/fsp/fsp-surveillance.c b/hw/fsp/fsp-surveillance.c index 202b0932ab..54e77cfa72 100644 --- a/hw/fsp/fsp-surveillance.c +++ b/hw/fsp/fsp-surveillance.c @@ -53,7 +53,7 @@ static void fsp_surv_ack(struct fsp_msg *msg) val = (msg->resp->word1 >> 8) & 0xff; if (val == 0) { /* reset the pending flag */ - prlog(PR_DEBUG, + prlog(PR_TRACE, "SURV: Received heartbeat acknowledge from FSP\n"); lock(&surv_lock); fsp_surv_ack_pending = false; @@ -115,7 +115,7 @@ static void fsp_surv_hbeat(void) if (surv_timer == 0 || (tb_compare(now, surv_timer) == TB_AAFTERB) || (tb_compare(now, surv_timer) == TB_AEQUALB)) { - prlog(PR_DEBUG, + prlog(PR_TRACE, "SURV: Sending the heartbeat command to FSP\n"); msg = fsp_mkmsg(FSP_CMD_SURV_HBEAT, 1, 120); if (!msg) {
These two prints just end up filling the skiboot logs on any machine that's been booted for more than a few hours. They have never been useful, so make them trace level. Signed-off-by: Michael Neuling <mikey@neuling.org> --- hw/fsp/fsp-surveillance.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)