| Message ID | 20170919091444.34950-1-didin@synopsys.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | qt: Allow enabling of QtWebKit with GCC 6+ | expand |
Hello, On Tue, 19 Sep 2017 12:14:44 +0300, Evgeniy Didin wrote: > Building Qt with QtWebKit on configuration step there is > a check which disables QtWebKit build with GCC 6+. > Back in the day nobody thought about building Qt with GCC > version greater than 5.x. And now with modern GCCs like > 6.x and 7.x this assumption gets in the way. > > Given in Buildroot today we don't have GCC older than 4.9 > it should be safe to remove now meaningless check completely. > > Signed-off-by: Evgeniy Didin <didin@synopsys.com> > Cc: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > --- > configure | 14 -------------- > 1 file changed, 14 deletions(-) I am not sure what you expect us to do with this patch: indeed it is not a Buildroot patch as Buildroot does not have a configure script. Perhaps you wanted instead to do a patch that adds a patch in package/qt/ instead ? Best regards, Thomas
Hi Evgeniy, In addition to Thomas's comment: On 19-09-17 11:14, Evgeniy Didin wrote: > Building Qt with QtWebKit on configuration step there is > a check which disables QtWebKit build with GCC 6+. > Back in the day nobody thought about building Qt with GCC > version greater than 5.x. And now with modern GCCs like > 6.x and 7.x this assumption gets in the way. > > Given in Buildroot today we don't have GCC older than 4.9 > it should be safe to remove now meaningless check completely. We actually support GCC down to 4.3 in external toolchains. But the check is only for 3.3 or older, so still OK. Regards, Arnout
diff --git a/configure b/configure index 10ad7ca0b0..8771144a65 100755 --- a/configure +++ b/configure @@ -7731,20 +7731,6 @@ case "$XPLATFORM" in canBuildWebKit="no" canBuildQtXmlPatterns="no" ;; - *-g++*) - # Check gcc's version - case "$(${QMAKE_CONF_COMPILER} -dumpversion)" in - 5*|4*|3.4*) - ;; - 3.3*) - canBuildWebKit="no" - ;; - *) - canBuildWebKit="no" - canBuildQtXmlPatterns="no" - ;; - esac - ;; solaris-cc*) # Check the compiler version case `${QMAKE_CONF_COMPILER} -V 2>&1 | awk '{print $4}'` in
Building Qt with QtWebKit on configuration step there is a check which disables QtWebKit build with GCC 6+. Back in the day nobody thought about building Qt with GCC version greater than 5.x. And now with modern GCCs like 6.x and 7.x this assumption gets in the way. Given in Buildroot today we don't have GCC older than 4.9 it should be safe to remove now meaningless check completely. Signed-off-by: Evgeniy Didin <didin@synopsys.com> Cc: Alexey Brodkin <abrodkin@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- configure | 14 -------------- 1 file changed, 14 deletions(-)